Unverified Commit d24eebdc authored by Weijia Wang's avatar Weijia Wang Committed by GitHub
Browse files

Merge pull request #259072 from cbrewster/nsc-darwin

nsc: disable check phase on darwin
parents 5d034685 47a05973
Loading
Loading
Loading
Loading
+11 −1
Original line number Diff line number Diff line
@@ -39,12 +39,22 @@ buildGoModule rec {
    export HOME=$(mktemp -d)
  '';

  # Tests currently fail on darwin because of a test in nsc which
  # expects command output to contain a specific path. However
  # the test strips table formatting from the command output in a naive way
  # that removes all the table characters, including '-'.
  # The nix build directory looks something like:
  # /private/tmp/nix-build-nsc-2.8.1.drv-0/nsc_test2000598938/keys
  # Then the `-` are removed from the path unintentionally and the test fails.
  # This should be fixed upstream to avoid mangling the path when
  # removing the table decorations from the command output.
  doCheck = !stdenv.isDarwin;

  meta = {
    description = "A tool for creating NATS account and user access configurations";
    homepage = "https://github.com/nats-io/nsc";
    license = with lib.licenses; [ asl20 ];
    maintainers = with lib.maintainers; [ cbrewster ];
    mainProgram = "nsc";
    broken = stdenv.isDarwin;
  };
}