Commit d07ab951 authored by Adam Joseph's avatar Adam Joseph Committed by Adam Joseph
Browse files

cc-wrapper: revert speculative commentary 

This commit deletes speculative comments which were self-merged with
no approvals in PR #275947.

If you think that "The above 'fix' may be incorrect" the correct
response is to submit a PR which removes the 'fix' and get it reviewed.

Likewise, if you think that "For clang it's not necessary" you
should submit a PR which wraps it in `if !isClang`.

`cc-wrapper` is full of too much junk as it is, let's not make
things worse.
parent a0eb127b

pkgs/build-support/cc-wrapper/default.nix

+0 −7
Original line number Diff line number Diff line
@@ -462,13 +462,6 @@ stdenv.mkDerivation { 
      echo "-L${gccForLibs}/lib/gcc/${targetPlatform.config}/${gccForLibs.version}" >> $out/nix-support/cc-ldflags

      echo "-L${gccForLibs_solib}/lib" >> $out/nix-support/cc-ldflags

    ''

    # The above "fix" may be incorrect; gcc.cc.lib doesn't contain a

    # `target-triple` dir but the correct fix may be to just remove the above?

    #

    # For clang it's not necessary (see `--gcc-toolchain` below) and for other

    # situations adding in the above will bring in lots of other gcc libraries

    # (i.e. sanitizer libraries, `libatomic`, `libquadmath`) besides just

    # `libstdc++`; this may actually break clang.



    # TODO We would like to connect this to `useGccForLibs`, but we cannot yet

    # because `libcxxStdenv` on linux still needs this. Maybe someday we'll