Unverified Commit cc997f28 authored by Jan Tojnar's avatar Jan Tojnar
Browse files

fish: switch to fetchFromGitHub 

The expression claimed there are differences between the release tarball and the tarball github packages from the tag but fetchFromGitHub literally downloads the same tarball.
parent f203d50d

pkgs/shells/fish/default.nix

+6 −6
Original line number Diff line number Diff line 
{ stdenv, fetchurl, coreutils, utillinux,

{ stdenv, fetchFromGitHub, coreutils, utillinux,

  which, gnused, gnugrep,

  groff, man-db, getent, libiconv, pcre2,

  gettext, ncurses, python3,
@@ -93,11 +93,11 @@ let 


    etcConfigAppendix = builtins.toFile "etc-config.appendix.fish" etcConfigAppendixText;



    src = fetchurl {

      # There are differences between the release tarball and the tarball github packages from the tag

      # Hence we cannot use fetchFromGithub

      url = "https://github.com/fish-shell/fish-shell/releases/download/${version}/${pname}-${version}.tar.gz";

      sha256 = "03j3jl9jzlnhq4p86zj8wqsh5sx45j1d1fvfa80ks1cfdg68qwhl";

    src = fetchFromGitHub {

      owner = "fish-shell";

      repo = "fish-shell";

      rev = version;

      sha256 = "1qh6dka1ayz352ihcq4529hjgnz255gyrqs3xyif6b2ycvrm4ad5";

    };



    nativeBuildInputs = [ cmake ];