Unverified Commit cad599f3 authored by Wolfgang Walther's avatar Wolfgang Walther
Browse files

top-level/by-name-overlay: remove optimization TODO 

We tried to apply this, but this won't consistently help performance.
While it can potentially make full eval a tad faster, we'd pay the price
when evaluating single packages.
parent cab0f8f3

pkgs/top-level/by-name-overlay.nix

+0 −4
Original line number Diff line number Diff line
@@ -41,10 +41,6 @@ let 
  # if the overlay has to be applied multiple times

  packageFiles = mergeAttrsList (mapAttrsToList namesForShard (readDir baseDirectory));

in

# TODO: Consider optimising this using `builtins.deepSeq packageFiles`,

# which could free up the above thunks and reduce GC times.

# Currently this would be hard to measure until we have more packages

# and ideally https://github.com/NixOS/nix/pull/8895

self: super:

{

  # This attribute is necessary to allow CI to ensure that all packages defined in `pkgs/by-name`