Commit c7c340e5 authored by Anderson Torres's avatar Anderson Torres
Browse files

smplayer: refactor 

- New rec-less, overlay-style overridable recursive attributes (in effect since
https://github.com/NixOS/nixpkgs/pull/119942);
- remove `with lib;`
- add `meta.changelog`
- "update" TODO
parent 83cd2a96

pkgs/applications/video/smplayer/default.nix

+10 −9
Original line number Diff line number Diff line
@@ -6,14 +6,14 @@ 
, wrapQtAppsHook

}:



stdenv.mkDerivation rec {

stdenv.mkDerivation (finalAttrs: {

  pname = "smplayer";

  version = "23.6.0";



  src = fetchFromGitHub {

    owner = "smplayer-dev";

    repo = pname;

    rev = "v${version}";

    repo = "smplayer";

    rev = "v${finalAttrs.version}";

    hash = "sha256-xGy6/9aUftBTSo9HJ3zyuRSagqimP9XvXKP/4oBQTo4=";

  };
@@ -32,7 +32,7 @@ stdenv.mkDerivation rec { 
    "PREFIX=${placeholder "out"}"

  ];



  meta = with lib; {

  meta = {

    homepage = "https://www.smplayer.info";

    description = "A complete front-end for MPlayer";

    longDescription = ''
@@ -53,9 +53,10 @@ stdenv.mkDerivation rec { 
      options of MPlayer, SMPlayer adds other interesting features like the

      possibility to play Youtube videos or download subtitles.

    '';

    license = licenses.gpl3Plus;

    maintainers = with maintainers; [ AndersonTorres ];

    platforms = platforms.linux;

    changelog = "https://github.com/smplayer-dev/smplayer/releases/tag/v${finalAttrs.version}";

    license = lib.licenses.gpl3Plus;

    maintainers = with lib.maintainers; [ AndersonTorres ];

    platforms = lib.platforms.linux;

  };

}

# TODO [ AndersonTorres ]: some form of wrapping mplayer/mpv around it
 
})

# TODO [ AndersonTorres ]: create a wrapper including mplayer/mpv