Unverified Commit c4548e58 authored by Wolfgang Walther's avatar Wolfgang Walther
Browse files

ci/github-script/bot: fix scheduled bot with older artifacts 

We only recently introduced the owners.txt file to the comparison
artifact, so once the bot runs on a schedule it will it older artifacts
very quickly - and then can't find the owners file.

We can fallback to an empty owners list in this case, because an older
artifact also means an older workflow run previously, so this will have
pinged owners already.
parent f095a1f2

ci/github-script/bot.js

+12 −4
Original line number Diff line number Diff line
@@ -375,6 +375,17 @@ module.exports = async ({ github, context, core, dry }) => { 
      })



      if (!pull_request.draft) {

        let owners = []

        try {

          // TODO: Create owner map similar to maintainer map.

          owners = (await readFile(`${pull_number}/owners.txt`, 'utf-8')).split(

            '\n',

          )

        } catch (e) {

          // Older artifacts don't have the owners.txt, yet.

          if (e.code !== 'ENOENT') throw e

        }



        // We set this label earlier already, but the current PR state can be very different

        // after handleReviewers has requested reviews, so update it in this case to prevent

        // this label from flip-flopping.
@@ -392,10 +403,7 @@ module.exports = async ({ github, context, core, dry }) => { 
              await readFile(`${pull_number}/maintainers.json`, 'utf-8'),

            ),

          ).map((id) => parseInt(id)),

          // TODO: Create owner map similar to maintainer map.

          owners: (await readFile(`${pull_number}/owners.txt`, 'utf-8')).split(

            '\n',

          ),

          owners,

          getTeamMembers,

          getUser,

        })