Commit c1710f23 authored by Silvan Mosberger's avatar Silvan Mosberger
Browse files

workflows/codeowners: Dry mode for now 

Apparently it started requesting reviews from code owners already
because the DRY_MODE from the global env was overridden in the local job
declaration: https://github.com/NixOS/nixpkgs/pull/347354#event-14570645380
parent 4f9b30c3

.github/workflows/codeowners.yml

+4 −5
Original line number Diff line number Diff line
@@ -15,11 +15,12 @@ on: 
env:

  # TODO: Once confirmed that this works by seeing that the action would request

  # reviews from the same people (or refuse for wrong base branches),

  # move all entries from CODEOWNERS to OWNERS and change this value here

  # OWNERS_FILE: .github/OWNERS

  # move all entries from CODEOWNERS to OWNERS, remove these two lines and uncomment the ones below

  OWNERS_FILE: .github/CODEOWNERS

  # Also remove this

  DRY_MODE: 1

  # OWNERS_FILE: .github/OWNERS

  # # Don't do anything on draft PRs

  # DRY_MODE: ${{ github.event.pull_request.draft && '1' || '' }}



jobs:

  # Check that code owners is valid
@@ -84,5 +85,3 @@ jobs: 
      run: result/bin/request-reviews.sh ${{ github.repository }} ${{ github.event.number }} "$OWNERS_FILE"

      env:

        GH_TOKEN: ${{ steps.app-token.outputs.token }}
 
        # Don't do anything on draft PRs

        DRY_MODE: ${{ github.event.pull_request.draft && '1' || '' }}