Commit bfc7aaa8 authored by Alyssa Ross's avatar Alyssa Ross
Browse files

wrapCCWith: disable pic when building for Windows 

According to <https://gcc.gnu.org/legacy-ml/gcc-patches/2015-08/msg00836.html>,
all code is position-independent on Windows.  Some compilers
apparently warn for -fPIC on Windows, and clang errors:

> clang-15: error: unsupported option '-fPIC' for target 'x86_64-pc-windows-msvc'

I'm guessing the check was hostPlatform instead of targetPlatform by mistake.
parent 2839c94f

pkgs/build-support/cc-wrapper/default.nix

+1 −1
Original line number Diff line number Diff line
@@ -518,7 +518,7 @@ stdenv.mkDerivation { 
    ''



    # TODO: categorize these and figure out a better place for them

    + optionalString hostPlatform.isCygwin ''

    + optionalString targetPlatform.isWindows ''

      hardening_unsupported_flags+=" pic"

    '' + optionalString targetPlatform.isMinGW ''

      hardening_unsupported_flags+=" stackprotector fortify"