Unverified Commit b79ac84d authored by Bobby Rong's avatar Bobby Rong
Browse files

nixos/budgie: Use gnome-terminal by default 

- Both budgie-desktop-view and cinnamon-desktop defaults to gnome-terminal, there
  are no clear reason why we don't use the defaults here.
  The cinnamon-desktop org.cinnamon.desktop.default-applications.terminal schema
  is used in nemo for default emulator, since we use nemo by default this fixes nemo
  open in terminal entry without introducing another override.
- There are theming issues with Qogir when opening right-click menu in a second tab.
- Transparency is broken when hovering on other windows, showing only the wallpaper.

This also ensures a stable default for budgie-desktop-view, by using only the
executable name and not a nix store path.

ref: https://github.com/BuddiesOfBudgie/budgie-desktop-view/blob/v1.3/data/org.buddiesofbudgie.budgie-desktop-view.gschema.xml#L60
ref: https://github.com/linuxmint/cinnamon-desktop/blob/6.0.0/schemas/org.cinnamon.desktop.default-applications.gschema.xml.in#L46
ref: https://github.com/linuxmint/nemo/blob/6.0.0/src/nemo-view.c#L7193
parent b5f838a2

nixos/doc/manual/release-notes/rl-2405.section.md

+2 −0
Original line number Diff line number Diff line
@@ -331,6 +331,8 @@ The pre-existing [services.ankisyncd](#opt-services.ankisyncd.enable) has been m 
  - Similarly, please use `services.xserver.desktopManager.mate.extraCajaExtensions` option for installing Caja extensions.

  - To use the Wayland session, enable `services.xserver.desktopManager.mate.enableWaylandSession`. This is opt-in for now as it is in early stage and introduces a new set of Wayfire closure. Due to [known issues with LightDM](https://github.com/canonical/lightdm/issues/63), we suggest using SDDM for display manager.



- The Budgie module installs gnome-terminal by default (instead of mate-terminal).



- New `boot.loader.systemd-boot.xbootldrMountPoint` allows setting up a separate [XBOOTLDR partition](https://uapi-group.org/specifications/specs/boot_loader_specification/) to store boot files. Useful on systems with a small EFI System partition that cannot be easily repartitioned.



- `boot.loader.systemd-boot` will now verify that `efiSysMountPoint` (and `xbootldrMountPoint` if configured) are mounted partitions.

nixos/modules/services/x11/desktop-managers/budgie.nix

+3 −1
Original line number Diff line number Diff line
@@ -144,7 +144,6 @@ in { 
          mate.atril

          mate.engrampa

          mate.mate-calc

          mate.mate-terminal

          mate.mate-system-monitor

          vlc
@@ -158,6 +157,9 @@ in { 
        ] config.environment.budgie.excludePackages)

      ++ cfg.sessionPath;



    # Both budgie-desktop-view and nemo defaults to this emulator.

    programs.gnome-terminal.enable = mkDefault true;



    # Fonts.

    fonts.packages = [

      pkgs.noto-fonts

nixos/tests/budgie.nix

+3 −3
Original line number Diff line number Diff line
@@ -82,9 +82,9 @@ import ./make-test-python.nix ({ pkgs, lib, ... }: { 
          machine.wait_until_succeeds("${su "budgie-screensaver-command -q"} | grep 'The screensaver is inactive'")

          machine.sleep(2)



      with subtest("Open MATE terminal"):

          machine.succeed("${su "mate-terminal >&2 &"}")

          machine.wait_for_window("Terminal")

      with subtest("Open GNOME terminal"):

          machine.succeed("${su "gnome-terminal"}")

          machine.wait_for_window("${user.name}@machine: ~")



      with subtest("Check if Budgie has ever coredumped"):

          machine.fail("coredumpctl --json=short | grep budgie")

pkgs/desktops/budgie/budgie-gsettings-overrides/default.nix

+0 −2
Original line number Diff line number Diff line
@@ -5,7 +5,6 @@ 
, glib

, gsettings-desktop-schemas

, gnome

, mate

, nixos-artwork

, nixos-background-light ? nixos-artwork.wallpapers.nineish

, nixos-background-dark ? nixos-artwork.wallpapers.nineish-dark-gray
@@ -54,7 +53,6 @@ let 
    [org.buddiesofbudgie.budgie-desktop-view:Budgie]

    show=true

    show-active-mounts=true

    terminal="${mate.mate-terminal}/bin/mate-terminal"



    ${extraGSettingsOverrides}

  '';