Unverified Commit b6b51374 authored by Michael Weiss's avatar Michael Weiss
Browse files

chromiumBeta: Fix errors due to incompatible Wayland headers 

This "fixes" errors like these:
```
FAILED: obj/third_party/angle/angle_gpu_info_util/SystemInfo_vulkan.o
[...]
In file included from ../../third_party/wayland/src/src/wayland-client.h:40:
/nix/store/an42rhwn6ck2nix6caikrr4rvizknjhh-wayland-1.21.0-dev/include/wayland-client-protocol.h:1040:13: error: use of undeclared identifier 'wl_proxy_marshal_flags'
        callback = wl_proxy_marshal_flags((struct wl_proxy *) wl_display,
                   ^
[...]
/nix/store/an42rhwn6ck2nix6caikrr4rvizknjhh-wayland-1.21.0-dev/include/wayland-client-protocol.h:1392:87: error: use of undeclared identifier 'WL_MARSHAL_FLAG_DESTROY'
                         WL_SHM_POOL_DESTROY, NULL, wl_proxy_get_version((struct wl_proxy *) wl_shm_pool), WL_MARSHAL_FLAG_DESTROY);
                                                                                                           ^
[...]
fatal error: too many errors emitted, stopping now [-ferror-limit=]
```

At least for now (until Chromium updates their bundled Wayland version) it
seems best to use the bundled headers/versions to avoid version incompatibility
issues (we should hopefully be able to drop use_system_wayland_scanner though).
parent 7851ae60

pkgs/applications/networking/browsers/chromium/common.nix

+4 −0
Original line number Diff line number Diff line
@@ -289,6 +289,10 @@ let 
      rtc_use_pipewire = true;

      # Disable PGO because the profile data requires a newer compiler version (LLVM 14 isn't sufficient):

      chrome_pgo_phase = 0;

    } // optionalAttrs (chromiumVersionAtLeast "105") {

      # https://bugs.chromium.org/p/chromium/issues/detail?id=1334390:

      use_system_libwayland = false;

      use_system_wayland_scanner = false;

    } // optionalAttrs proprietaryCodecs {

      # enable support for the H.264 codec

      proprietary_codecs = true;