Commit b3a27afb authored by Will Fancher's avatar Will Fancher
Browse files

binfmt: Don't create invalid service with no registrations 

We shouldn't be creating a systemd.services.systemd-binfmt value when
the upstream unit isn't being pulled in, because it results in a
service unit file with no ExecStart line
parent f30a2734

nixos/modules/system/boot/binfmt.nix

+8 −6
Original line number Diff line number Diff line
@@ -316,11 +316,13 @@ in { 
      mkdir -p -m 0755 /run/binfmt

      ${lib.concatStringsSep "\n" (lib.mapAttrsToList activationSnippet config.boot.binfmt.registrations)}

    '';

    systemd.additionalUpstreamSystemUnits = lib.mkIf (config.boot.binfmt.registrations != {}) [

    systemd = lib.mkIf (config.boot.binfmt.registrations != {}) {

      additionalUpstreamSystemUnits = [

        "proc-sys-fs-binfmt_misc.automount"

        "proc-sys-fs-binfmt_misc.mount"

        "systemd-binfmt.service"

      ];

    systemd.services.systemd-binfmt.restartTriggers = [ (builtins.toJSON config.boot.binfmt.registrations) ];

      services.systemd-binfmt.restartTriggers = [ (builtins.toJSON config.boot.binfmt.registrations) ];

    };

  };

}