Commit b12debc0 authored by jokogr's avatar jokogr Committed by Franz Pletz
Browse files

grub: Do not check for duplicated devices in mirroredBoots on UEFI (#18625) 

When Grub is to be used with UEFI, it is not going to write to any MBR
of any disk. As such, it is safe to use multiple "nodev" device entries
when mirroring the ESP partition to multiple disks.

E.g.:

```
boot.loader.grub = {
  enable = true;
  version = 2;
  zfsSupport = true;
  efiSupport = true;
  mirroredBoots = [
    { devices = [ "nodev" ]; path = "/boot1"; efiSysMountPoint = "/boot1"; }
    { devices = [ "nodev" ]; path = "/boot2"; efiSysMountPoint = "/boot2"; }
    { devices = [ "nodev" ]; path = "/boot3"; efiSysMountPoint = "/boot3"; }
  ];
};

boot.loader.efi.canTouchEfiVariables = true;
```

Fixes #18584
parent 60f31c60

nixos/modules/system/boot/loader/grub/grub.nix

+1 −1
Original line number Diff line number Diff line
@@ -503,7 +503,7 @@ in 
            + "'boot.loader.grub.mirroredBoots' to make the system bootable.";

        }

        {

          assertion = all (c: c < 2) (mapAttrsToList (_: c: c) bootDeviceCounters);

          assertion = cfg.efiSupport || all (c: c < 2) (mapAttrsToList (_: c: c) bootDeviceCounters);

          message = "You cannot have duplicated devices in mirroredBoots";

        }

        {