Commit a6d2eba0 authored by Connor Baker's avatar Connor Baker Committed by github-actions[bot]
Browse files

python312Packages.ax: disable tests on Python 3.12 

The test suite has a number of failures (not limited to):

FAILED ax/analysis/helpers/tests/test_cross_validation_helpers.py::TestCrossValidationHelpers::test_get_min_max_with_errors - SystemError: <sys.legacy_event_handler object at 0x7ffc5029cdb0> returned a...
FAILED ax/analysis/helpers/tests/test_cross_validation_helpers.py::TestCrossValidationHelpers::test_obs_vs_pred_dropdown_plot - SystemError: <sys.legacy_event_handler object at 0x7ffc5029cdb0> returned a...
FAILED ax/analysis/helpers/tests/test_cross_validation_helpers.py::TestCrossValidationHelpers::test_store_df_to_file - SystemError: <sys.legacy_event_handler object at 0x7ffc5029cdb0> returned a...
FAILED ax/analysis/helpers/tests/test_cross_validation_helpers.py::TestCrossValidationHelpers::test_store_plot_as_dict - SystemError: <sys.legacy_event_handler object at 0x7ffc5029cdb0> returned a...
FAILED ax/analysis/helpers/tests/test_cv_consistency_checks.py::TestCVConsistencyCheck::test_error_scatter_data_branin - SystemError: <sys.legacy_event_handler object at 0x7ffc5029cdb0> returned a...
FAILED ax/analysis/helpers/tests/test_cv_consistency_checks.py::TestCVConsistencyCheck::test_error_scatter_trace_branin - SystemError: <sys.legacy_event_handler object at 0x7ffc5029cdb0> returned a...

Irritatingly enough, disabling those tests causes (or allows?) different tests to fail. After chasing these for some time, it proved easier to disable the test suite for Python 3.12.

(cherry picked from commit 13e2dcabbc871b8d83793747d43ed43cf7a13d95)
parent 75524589

pkgs/development/python-modules/ax/default.nix

+7 −0
Original line number Diff line number Diff line
@@ -2,11 +2,13 @@ 
  lib,

  buildPythonPackage,

  fetchFromGitHub,

  ax,

  botorch,

  ipywidgets,

  jinja2,

  pandas,

  plotly,

  python,

  setuptools,

  setuptools-scm,

  typeguard,
@@ -79,6 +81,11 @@ buildPythonPackage rec { 
  ];

  pythonImportsCheck = [ "ax" ];



  # Many portions of the test suite fail under Python 3.12

  doCheck = lib.versions.majorMinor python.version != "3.12";



  passthru.tests.check = ax.overridePythonAttrs { doCheck = true; };



  meta = with lib; {

    description = "Ax is an accessible, general-purpose platform for understanding, managing, deploying, and automating adaptive experiments";

    homepage = "https://ax.dev/";