Unverified Commit a56b85eb authored by Fabian Affolter's avatar Fabian Affolter Committed by GitHub
Browse files

Merge pull request #229716 from fabaff/runway-python-remove

python310Packages.rl-coach: remove
parents 22439437 9ae92527
Loading
Loading
Loading
Loading
+0 −99
Original line number Diff line number Diff line
{ lib
, buildPythonPackage
, pythonOlder
, fetchPypi
, tensorflow
, annoy
, pillow
, matplotlib
, numpy
, pandas
, pygame
, pyopengl
, scipy
, scikitimage
, gym
, bokeh
, kubernetes
, redis
, minio
, pytest
, psutil
}:

buildPythonPackage rec {
  version = "1.0.1";
  pname = "rl-coach";

  src = fetchPypi {
    inherit pname version;
    sha256 = "0i47hf0l76ydyrky6f8h760bfr0zg5g3vy675x6m6pgm9wrklkqc";
  };

  propagatedBuildInputs = [
    tensorflow
    annoy
    pillow
    matplotlib
    numpy
    pandas
    pygame
    pyopengl
    scipy
    scikitimage
    gym
    bokeh
    kubernetes
    redis
    minio
    psutil
  ];

  nativeCheckInputs = [
    pytest
  ];

  # run only some tests that do not need any optional dependencies
  # available tests: https://github.com/NervanaSystems/coach/tree/master/rl_coach/tests
  testsToRun = [
    # test only the tensorflow backend (not mxnet)
    "architectures/tensorflow_components"
    "agents"
    "exploration_policies"
    "filters"
    "memories"
    "utils"
  ];
  checkPhase = let
    fullTestPaths = map (testfile: "rl_coach/tests/${testfile}") testsToRun;
    escapedPaths = map lib.escapeShellArg fullTestPaths;
    pytestArgs = builtins.concatStringsSep " " escapedPaths;
  in
  ''
    pytest ${pytestArgs}
  '';

  postPatch = ''
    # pinned to 8.0.1 for unknown reason, at least basic functionallity seems to work without it
    # https://github.com/NervanaSystems/coach/pull/149#issuecomment-495915804
    sed -i '/kubernetes/d' requirements.txt

    # this is just an "intel-optimized" version of tensorflow, e.g. an implementation detail
    sed -i 's/intel-tensorflow/tensorflow/g' setup.py

    # backports of python3 features not needed
    # https://github.com/NervanaSystems/coach/issues/324
    sed -i '/futures/d' requirements.txt
  '';

  disabled = pythonOlder "3.5"; # minimum required version

  meta = with lib; {
    description = "Enables easy experimentation with state of the art Reinforcement Learning algorithms";
    homepage = "https://nervanasystems.github.io/coach/";
    license = licenses.asl20;
    maintainers = with maintainers; [ timokau ];
    # pythonPackages.gym is too new
    broken = true; # since 2020-04-20
  };
}
+1 −0
Original line number Diff line number Diff line
@@ -254,6 +254,7 @@ mapAliases ({
  requests_oauthlib = requests-oauthlib; # added 2022-02-12
  requests_toolbelt = requests-toolbelt; # added 2017-09-26
  rig = throw "rig has been removed because it was pinned to python 2.7 and 3.5, failed to build and is otherwise unmaintained"; # added 2022-11-28
  rl-coach = "rl-coach was removed because the project is discontinued and was archived by upstream"; # added 2023-05-03
  roboschool = throw "roboschool is deprecated in favor of PyBullet and has been removed"; # added 2022-01-15
  ROPGadget = ropgadget; # added 2021-07-06
  rotate-backups = throw "rotate-backups was removed in favor of the top-level rotate-backups"; # added 2021-07-01
+0 −2
Original line number Diff line number Diff line
@@ -10446,8 +10446,6 @@ self: super: with self; {

  rlax = callPackage ../development/python-modules/rlax { };

  rl-coach = callPackage ../development/python-modules/rl-coach { };

  rlp = callPackage ../development/python-modules/rlp { };

  rmcl = callPackage ../development/python-modules/rmcl { };