Commit 9c3d8652 authored by teto's avatar teto
Browse files

neovim: disable python3 and ruby providers by default 

Providers are the thing I spend most of my time on while admittedly very
few users use it (I can only think of deoplete now) and it's going to disappear anyway.
We have no tests for it because of the previous reasons.

Before this patch:
nix path-info -Sh .#neovim
/nix/store/smd007xlbsx35y42rri5xlqhjgajz9in-neovim-0.11.6	365.0 MiB

After:
nix path-info -Sh .#neovim
/nix/store/4cr60j05l3pirhhrcs5hqb9rzj854n5r-neovim-0.11.6	240.6 MiB

To restore old behavior, pass `{withPython3= true; withRuby = true; }`
to the neovim wrapper.
parent d2952788

doc/release-notes/rl-2605.section.md

+1 −0
Original line number Diff line number Diff line
@@ -201,6 +201,7 @@ 


- `mold` is now wrapped by default.



- `neovim` now disables by default the `python3` and `ruby` providers, unused by most users and reducing closure size from 365MiB to 240MiB.



### Deprecations {#sec-nixpkgs-release-26.05-lib-deprecations}

pkgs/applications/editors/neovim/utils.nix

+3 −3
Original line number Diff line number Diff line
@@ -177,7 +177,7 @@ let 
      # the function you would have passed to python.withPackages

      extraPythonPackages ? (_: [ ]),

      # the function you would have passed to python.withPackages

      withPython3 ? true,

      withPython3 ? false,

      extraPython3Packages ? (_: [ ]),

      # the function you would have passed to lua.withPackages

      extraLuaPackages ? (_: [ ]),
@@ -243,9 +243,9 @@ let 
  */

  generateProviderRc =

    {

      withPython3 ? true,

      withPython3 ? false,

      withNodeJs ? false,

      withRuby ? true,

      withRuby ? false,

      # Perl is problematic https://github.com/NixOS/nixpkgs/issues/132368

      withPerl ? false,

pkgs/applications/editors/neovim/wrapper.nix

+2 −2
Original line number Diff line number Diff line
@@ -37,14 +37,14 @@ let 
      # should contain all args but the binary. Can be either a string or list

      wrapperArgs ? [ ],

      withPython2 ? false,

      withPython3 ? true,

      withPython3 ? false,

      # the function you would have passed to python3.withPackages

      extraPython3Packages ? (_: [ ]),



      waylandSupport ? lib.meta.availableOn stdenv.hostPlatform wayland,

      withNodeJs ? false,

      withPerl ? false,

      withRuby ? true,

      withRuby ? false,



      # wether to create symlinks in $out/bin/vi(m) -> $out/bin/nvim

      vimAlias ? false,