Commit 8da01484 authored by Robert Hensing's avatar Robert Hensing
Browse files

pkgs/stdenv/adapters.nix: Rename internal name 

`finalAttrs` is never the first argument. This should have been
called `prevAttrs` all along.
It confused me for a bit, because the callback _must not_ be strict
in `finalAttrs` (the first of _two_ parameters), or it will
recurse infinitely while trying to figure out what the attrNames are.
parent 8437d13b

pkgs/stdenv/adapters.nix

+3 −3
Original line number Diff line number Diff line
@@ -144,10 +144,10 @@ rec { 
    # extraBuildInputs are dropped in cross.nix, but darwin still needs them

    extraBuildInputs = [ pkgs.buildPackages.darwin.CF ];

    mkDerivationFromStdenv = withOldMkDerivation old (stdenv: mkDerivationSuper: args:

    (mkDerivationSuper args).overrideAttrs (finalAttrs: {

      NIX_CFLAGS_LINK = toString (finalAttrs.NIX_CFLAGS_LINK or "")

    (mkDerivationSuper args).overrideAttrs (prevAttrs: {

      NIX_CFLAGS_LINK = toString (prevAttrs.NIX_CFLAGS_LINK or "")

        + lib.optionalString (stdenv.cc.isGNU or false) " -static-libgcc";

      nativeBuildInputs = (finalAttrs.nativeBuildInputs or [])

      nativeBuildInputs = (prevAttrs.nativeBuildInputs or [])

        ++ lib.optionals stdenv.hasCC [

          (pkgs.buildPackages.makeSetupHook {

            name = "darwin-portable-libSystem-hook";