Commit 8aba8953 authored by Robert Schütz's avatar Robert Schütz
Browse files

bitwarden: simplify expression 

We now use hooks to setup Rust dependencies, rely on upstream's
package.json to compile the Rust code, and support nix-update.
parent 572fc1a5

pkgs/tools/security/bitwarden/default.nix

+64 −66
Original line number Diff line number Diff line 
{ lib

, applyPatches

, buildNpmPackage

, cargo

, dbus

, electron_24

, fetchFromGitHub
@@ -15,8 +16,8 @@ 
, nodejs_18

, pkg-config

, python3

, rustc

, rustPlatform

, wrapGAppsHook

}:



let
@@ -26,8 +27,18 @@ let 
  buildNpmPackage' = buildNpmPackage.override { nodejs = nodejs_18; };

  electron = electron_24;



  desktopItem = makeDesktopItem {

    name = "bitwarden";

    exec = "bitwarden %U";

    inherit icon;

    comment = description;

    desktopName = "Bitwarden";

    categories = [ "Utility" ];

  };

in buildNpmPackage' rec {

  pname = "bitwarden";

  version = "2023.8.3";

  src = applyPatches {



  src = fetchFromGitHub {

    owner = "bitwarden";

    repo = "clients";
@@ -35,18 +46,30 @@ let 
    hash = "sha256-ZsAc9tC087Em/VzgaVm5fU+JnI4gIsSAphxicdJWztU=";

  };



    patches = [ ];

  makeCacheWritable = true;

  npmWorkspace = "apps/desktop";

  npmDepsHash = "sha256-ARq6iYOkL9CMyAX37g8+Wf+UQsH7hU1jCq/52I1qS9A=";



  cargoDeps = rustPlatform.fetchCargoTarball {

    name = "${pname}-${version}";

    inherit src;

    sourceRoot = "${src.name}/${cargoRoot}";

    hash = "sha256-ABMrFXOR0IwsMv0pxvkebzCUbs18BOGwiuGcEZFntd0=";

  };

  cargoRoot = "apps/desktop/desktop_native";



  desktop-native = rustPlatform.buildRustPackage {

    pname = "bitwarden-desktop-native";

    inherit src version;

    sourceRoot = "${src.name}/apps/desktop/desktop_native";

    cargoHash = "sha256-iBZvdBfuZtcoSgyU4B58ARIBplqUuT5bRev9qnk9LpE=";

  env.ELECTRON_SKIP_BINARY_DOWNLOAD = "1";



  nativeBuildInputs = [

    cargo

    jq

    makeWrapper

    moreutils

    pkg-config

      wrapGAppsHook

    python3

    rustc

    rustPlatform.cargoCheckHook

    rustPlatform.cargoSetupHook

  ];



  buildInputs = [
@@ -55,6 +78,29 @@ let 
    libsecret

  ];



  preBuild = ''

    if [[ $(jq --raw-output '.devDependencies.electron' < package.json | grep -E --only-matching '^[0-9]+') != ${lib.escapeShellArg (lib.versions.major electron.version)} ]]; then

      echo 'ERROR: electron version mismatch'

      exit 1

    fi

  '';



  postBuild = ''

    pushd apps/desktop



    # desktop_native/index.js loads a file of that name regarldess of the libc being used

    mv desktop_native/desktop_native.* desktop_native/desktop_native.linux-x64-musl.node



    npm exec electron-builder -- \

      --dir \

      -c.electronDist=${electron}/libexec/electron \

      -c.electronVersion=${electron.version}



    popd

  '';



  doCheck = true;



  nativeCheckInputs = [

    dbus

    (gnome.gnome-keyring.override { useWrappedDaemon = false; })
@@ -67,65 +113,16 @@ let 
  checkPhase = ''

    runHook preCheck



    pushd ${cargoRoot}

    export HOME=$(mktemp -d)

    export -f cargoCheckHook runHook _eval _callImplicitHook

    export cargoCheckType=release

    dbus-run-session \

      --config-file=${dbus}/share/dbus-1/session.conf \

      -- bash -e -c cargoCheckHook

      runHook postCheck

    '';

  };



  desktopItem = makeDesktopItem {

    name = "bitwarden";

    exec = "bitwarden %U";

    inherit icon;

    comment = description;

    desktopName = "Bitwarden";

    categories = [ "Utility" ];

  };



in



buildNpmPackage' {

  pname = "bitwarden";

  inherit src version;



  makeCacheWritable = true;

  npmBuildFlags = [

    "--workspace apps/desktop"

  ];

  npmDepsHash = "sha256-ARq6iYOkL9CMyAX37g8+Wf+UQsH7hU1jCq/52I1qS9A=";



  ELECTRON_SKIP_BINARY_DOWNLOAD = "1";



  nativeBuildInputs = [

    jq

    makeWrapper

    moreutils

    python3

  ];



  preBuild = ''

    if [[ $(jq --raw-output '.devDependencies.electron' < package.json | grep -E --only-matching '^[0-9]+') != ${lib.escapeShellArg (lib.versions.major electron.version)} ]]; then

      echo 'ERROR: electron version mismatch'

      exit 1

    fi



    jq 'del(.scripts.postinstall)' apps/desktop/package.json | sponge apps/desktop/package.json

    jq '.scripts.build = ""' apps/desktop/desktop_native/package.json | sponge apps/desktop/desktop_native/package.json

    cp ${desktop-native}/lib/libdesktop_native.so apps/desktop/desktop_native/desktop_native.linux-x64-musl.node

  '';



  postBuild = ''

    pushd apps/desktop



    npm exec electron-builder -- \

      --dir \

      -c.electronDist=${electron}/libexec/electron \

      -c.electronVersion=${electron.version}



    popd



    runHook postCheck

  '';



  installPhase = ''
@@ -154,11 +151,12 @@ buildNpmPackage' { 
    popd

  '';



  meta = with lib; {

  meta = {

    changelog = "https://github.com/bitwarden/clients/releases/tag/${src.rev}";

    inherit description;

    homepage = "https://bitwarden.com";

    license = lib.licenses.gpl3;

    maintainers = with maintainers; [ amarshall kiwi ];

    maintainers = with lib.maintainers; [ amarshall kiwi ];

    platforms = [ "x86_64-linux" ];

  };

}