Commit 899fd8a2 authored by Jan Tojnar's avatar Jan Tojnar
Browse files

treewide: Comment out `webkitgtk_4_0` 

`webkitgtk_4_0` was already transitively insecure because of `libsoup_2_4` and it will be removed soon.

Ideally, we would just replace it with `libsoup_3`-based `webkitgtk_4_1`
but it is unclear if they would work with the 4.1 ABI. At best, the programs
would only be looking for 4.0, failing to build or start, at worst there
might be conflicts with libsoup 2 symbols if that is pulled in by anything
or crashes that will only happen after certain action.

Let’s mark the packages as broken to ensure human intervention.
parent 87f93d54

pkgs/applications/networking/remote/citrix-workspace/generic.nix

+4 −2
Original line number Diff line number Diff line
@@ -54,7 +54,7 @@ 
  symlinkJoin,

  systemd,

  tzdata,

  webkitgtk_4_0,

  # webkitgtk_4_0,

  which,

  xorg,

  zlib,
@@ -173,7 +173,7 @@ stdenv.mkDerivation rec { 
    speex

    stdenv.cc.cc

    (lib.getLib systemd)

    webkitgtk_4_0

    # webkitgtk_4_0

    xorg.libXScrnSaver

    xorg.libXaw

    xorg.libXmu
@@ -313,6 +313,8 @@ stdenv.mkDerivation rec { 
  '';



  meta = with lib; {

    # webkitgtk_4_0 was removed

    broken = true;

    license = licenses.unfree;

    description = "Citrix Workspace";

    sourceProvenance = with sourceTypes; [ binaryNativeCode ];

pkgs/by-name/al/alexandria/package.nix

+4 −2
Original line number Diff line number Diff line
@@ -3,7 +3,7 @@ 
  lib,

  fetchFromGitHub,

  pkg-config,

  webkitgtk_4_0,

  # webkitgtk_4_0,

  openssl,

  nodejs,

  npmHooks,
@@ -52,13 +52,15 @@ rustPlatform.buildRustPackage rec { 


  buildInputs = [

    openssl

    webkitgtk_4_0

    # webkitgtk_4_0

    gtk3

    librsvg

    libappindicator-gtk3

  ];



  meta = {

    # webkitgtk_4_0 was removed

    broken = true;

    homepage = "https://github.com/btpf/Alexandria";

    changelog = "https://github.com/btpf/Alexandria/releases/tag/v${version}";

    description = "Minimalistic cross-platform eBook reader";

pkgs/by-name/am/am2rlauncher/package.nix

+4 −2
Original line number Diff line number Diff line
@@ -5,7 +5,7 @@ 
  glibc,

  gtk3,

  libappindicator,

  webkitgtk_4_0,

  # webkitgtk_4_0,

  e2fsprogs,

  libnotify,

  libgit2,
@@ -67,7 +67,7 @@ buildDotnetModule { 
    glibc

    gtk3

    libappindicator

    webkitgtk_4_0

    # webkitgtk_4_0

    e2fsprogs

    libnotify

    libgit2
@@ -116,6 +116,8 @@ buildDotnetModule { 
  '';



  meta = with lib; {

    # webkitgtk_4_0 was removed

    broken = true;

    homepage = "https://github.com/AM2R-Community-Developers/AM2RLauncher";

    description = "Front-end for dealing with AM2R updates and mods";

    longDescription = ''

pkgs/by-name/ba/balsa/package.nix

+4 −2
Original line number Diff line number Diff line
@@ -19,7 +19,7 @@ 
  ninja,

  pkg-config,

  sqlite,

  webkitgtk_4_0,

  # webkitgtk_4_0,

  wrapGAppsHook3,

}:
@@ -57,7 +57,7 @@ stdenv.mkDerivation (finalAttrs: { 
    libsecret

    openssl

    sqlite

    webkitgtk_4_0

    # webkitgtk_4_0

  ];



  mesonFlags = [
@@ -78,6 +78,8 @@ stdenv.mkDerivation (finalAttrs: { 
  enableParallelBuilding = true;



  meta = {

    # webkitgtk_4_0 was removed

    broken = true;

    description = "E-mail client for GNOME";

    homepage = "https://gitlab.gnome.org/GNOME/balsa";

    changelog = "https://gitlab.gnome.org/GNOME/balsa/-/blob/master/ChangeLog";

pkgs/by-name/bi/bitcomet/package.nix

+4 −2
Original line number Diff line number Diff line
@@ -6,7 +6,7 @@ 
  fetchurl,

  desktop-file-utils,

  dpkg,

  webkitgtk_4_0,

  # webkitgtk_4_0,

  runScript ? "BitComet",

}:
@@ -15,6 +15,8 @@ let 
  version = "2.15.0";



  meta = {

    # webkitgtk_4_0 was removed

    broken = true;

    homepage = "https://www.bitcomet.com";

    description = "BitTorrent download client";

    mainProgram = "BitComet";
@@ -82,7 +84,7 @@ buildFHSEnv { 
    pkgs:

    [

      bitcomet

      webkitgtk_4_0

      # webkitgtk_4_0

    ]

    ++ appimageTools.defaultFhsEnvArgs.targetPkgs pkgs;