Unverified Commit 872987d0 authored by Kerstin's avatar Kerstin Committed by GitHub
Browse files

beam/mixRelease: default stripDebug to false due frequent runtime errors (#232107) 

This flag appears to cause issues in 3 out 4 users of mixRelease in
Nixpkgs, plus Mobilizon, which isn't merged yet. It might be safer to
set it to fals for now, as the runtime error messages produced by it are
quite cryptic.
parent c8f6370f

pkgs/development/beam-modules/elixir-ls/default.nix

+2 −0
Original line number Diff line number Diff line
@@ -16,6 +16,8 @@ in 
mixRelease  {

  inherit pname version src elixir;



  stripDebug = true;



  mixFodDeps = fetchMixDeps {

    pname = "mix-deps-${pname}";

    inherit src version elixir;

pkgs/development/beam-modules/mix-release.nix

+10 −1
Original line number Diff line number Diff line
@@ -9,16 +9,25 @@ 
, enableDebugInfo ? false

, mixEnv ? "prod"

, compileFlags ? [ ]



  # mix fixed output derivation dependencies

, mixFodDeps ? null



  # mix dependencies generated by mix2nix

  # this assumes each dependency is built by buildMix or buildRebar3

  # each dependency needs to have a setup hook to add the lib path to $ERL_LIBS

  # this is how mix will find dependencies

, mixNixDeps ? { }



, elixir ? inputs.elixir

, hex ? inputs.hex.override { inherit elixir; }

, stripDebug ? true



# This reduces closure size, but can lead to some hard to understand runtime

# errors, so use with caution. See e.g.

# https://github.com/whitfin/cachex/issues/205

# https://framagit.org/framasoft/mobilizon/-/issues/1169

, stripDebug ? false



, ...

}@attrs:

let

pkgs/servers/akkoma/default.nix

+0 −3
Original line number Diff line number Diff line
@@ -31,9 +31,6 @@ beamPackages.mixRelease rec { 
    mix phx.digest --no-deps-check

  '';



  # cf. https://github.com/whitfin/cachex/issues/205

  stripDebug = false;



  mixNixDeps = import ./mix.nix {

    inherit beamPackages lib;

    overrides = (final: prev: {

pkgs/servers/pleroma/default.nix

+0 −1
Original line number Diff line number Diff line
@@ -17,7 +17,6 @@ beamPackages.mixRelease rec { 
    rev = "v${version}";

    sha256 = "sha256-3iG2s7jVEnhq1kLLgtaHnFmLYBO2Xr5M5jjZfSNA9z4=";

  };

  stripDebug = false;



  mixNixDeps = import ./mix.nix {

    inherit beamPackages lib;

pkgs/servers/web-apps/plausible/default.nix

+0 −3
Original line number Diff line number Diff line
@@ -49,9 +49,6 @@ beamPackages.mixRelease { 


  nativeBuildInputs = [ nodejs ];



  # https://github.com/whitfin/cachex/issues/205

  stripDebug = false;



  passthru = {

    tests = { inherit (nixosTests) plausible; };

    updateScript = ./update.sh;