Unverified Commit 7f9f7a20 authored by Wolfgang Walther's avatar Wolfgang Walther
Browse files

ci/github-script/labels: limit cutoff to max 1 day 

It has only happened once, but the GitHub API suddenly returned a
workflow run from a few weeks back. This lead to quickly hitting the
rate limit for search requests.

Prevent this from happening by going back a day max for the "recently
updated" case. After roughly a day, every PR will have been touched by
the regular batch processing anyway.

Also save a few API requests, by taking bigger chunks of the search
result.
parent f7c34b08

ci/github-script/labels.js

+10 −4
Original line number Diff line number Diff line
@@ -292,11 +292,16 @@ module.exports = async function ({ github, context, core, dry }) { 
        })

      ).data.workflow_runs[0]



      const cutoff = new Date(

        Math.max(

          // Go back as far as the last successful run of this workflow to make sure

          // we are not leaving anyone behind on GHA failures.

          // Defaults to go back 1 hour on the first run.

      const cutoff = new Date(

        lastRun?.created_at ?? new Date().getTime() - 1 * 60 * 60 * 1000,

          new Date(lastRun?.created_at ?? new Date().getTime() - 1 * 60 * 60 * 1000).getTime(),

          // Go back max. 1 day to prevent hitting all API rate limits immediately,

          // when GH API returns a wrong workflow by accident.

          new Date().getTime() - 24 * 60 * 60 * 1000,

        ),

      )

      core.info('cutoff timestamp: ' + cutoff.toISOString())
@@ -308,6 +313,7 @@ module.exports = async function ({ github, context, core, dry }) { 
            'is:open',

            `updated:>=${cutoff.toISOString()}`,

          ].join(' AND '),

          per_page: 100,

          // TODO: Remove in 2025-10, when it becomes the default.

          advanced_search: true,

        },