Unverified Commit 7b3261b5 authored by Mikael Voss's avatar Mikael Voss
Browse files

nixos/pam: Strip config in documentation and messages 

config can be assumed as the options root and is therefore redundant.
parent 6c843e11

nixos/modules/security/pam.nix

+3 −4
Original line number Diff line number Diff line
@@ -1168,8 +1168,7 @@ in 


          If set, users can authenticate with their Kerberos password.

          This requires a valid Kerberos configuration

          (`config.security.krb5.enable` should be set to

          `true`).

          (`security.krb5.enable` should be set to `true`).



          Note that the Kerberos PAM modules are not necessary when using SSS

          to handle Kerberos authentication.
@@ -1587,8 +1586,8 @@ in 


    warnings = lib.optional

      (with config.security.pam.sshAgentAuth;

        enable && lib.any (s: lib.hasPrefix "%h" s || lib.hasPrefix "~" s) authorizedKeysFiles)

      ''config.security.pam.sshAgentAuth.authorizedKeysFiles contains files in the user's home directory.

        enable && lib.any (s: lib.hasPrefix "%h" s || lib.hasPrefix "~" s) authorizedKeysFiles) ''

        security.pam.sshAgentAuth.authorizedKeysFiles contains files in the user's home directory.



        Specifying user-writeable files there result in an insecure configuration:

        a malicious process can then edit such an authorized_keys file and bypass the ssh-agent-based authentication.