Unverified Commit 746a9744 authored by Martin Weinelt's avatar Martin Weinelt
Browse files

python310Packages.get-video-properties: remove vulnerable binaries 

We patched out their usage, but never removed the binaries from the
package.

A good time to migrate the package to the headless version of ffmpeg.
parent 623644ec

pkgs/development/python-modules/get-video-properties/default.nix

+5 −2
Original line number Diff line number Diff line 
{ lib

, buildPythonPackage

, fetchFromGitHub

, ffmpeg

, ffmpeg-headless

}:



buildPythonPackage rec {
@@ -20,7 +20,10 @@ buildPythonPackage rec { 


  postPatch = ''

    substituteInPlace videoprops/__init__.py \

      --replace "which('ffprobe')" "'${ffmpeg}/bin/ffprobe'"

      --replace "which('ffprobe')" "'${ffmpeg-headless}/bin/ffprobe'"



    # unused and vulnerable to various CVEs

    rm -r videoprops/binary_dependencies

  '';



  pythonImportsCheck = [ "videoprops" ];