Unverified Commit 6bffef7a authored by Fabian Affolter's avatar Fabian Affolter Committed by GitHub
Browse files

Merge pull request #303650 from fabaff/publicsuffix2-refactor

python312Packages.publicsuffix2: refactor, python312Packages.publicsuffix: refactor
parents 4b7e0af6 e147a147
Loading
Loading
Loading
Loading
+16 −4
Original line number Diff line number Diff line
{ lib, buildPythonPackage, fetchPypi }:
{
  lib,
  buildPythonPackage,
  fetchPypi,
  setuptools,
  pythonOlder,
}:

buildPythonPackage rec {
  pname = "publicsuffix";
  version = "1.1.1";
  format = "setuptools";
  pyproject = true;

  disabled = pythonOlder "3.7";

  src = fetchPypi {
    inherit pname version;
    sha256 = "22ce1d65ab6af5e9b2122e2443facdb93fb5c4abf24138099cb10fe7989f43b6";
    hash = "sha256-Is4dZatq9emyEi4kQ/rNuT+1xKvyQTgJnLEP55ifQ7Y=";
  };


  # disable test_fetch and the doctests (which also invoke fetch)
  postPatch = ''
    sed -i -e "/def test_fetch/i\\
    \\t@unittest.skip('requires internet')" -e "/def additional_tests():/,+1d" tests.py
  '';

  build-system = [ setuptools ];

  pythonImportsCheck = [ "publicsuffix" ];

  meta = with lib; {
    description = "Allows to get the public suffix of a domain name";
    homepage = "https://pypi.python.org/pypi/publicsuffix/";
    license = licenses.mit;
    maintainers = with maintainers; [ ];
  };
}
+11 −4
Original line number Diff line number Diff line
{ lib, buildPythonPackage, fetchFromGitHub }:
{
  lib,
  buildPythonPackage,
  fetchFromGitHub,
  setuptools,
}:
let
  tagVersion = "2.2019-12-21";
in
@@ -7,15 +12,17 @@ buildPythonPackage {
  # tags have dashes, while the library version does not
  # see https://github.com/nexB/python-publicsuffix2/issues/12
  version = lib.replaceStrings [ "-" ] [ "" ] tagVersion;
  format = "setuptools";
  pyproject = true;

  src = fetchFromGitHub {
    owner = "nexB";
    repo = "python-publicsuffix2";
    rev = "release-${tagVersion}";
    sha256 = "1dkvfvl0izq9hqzilnw8ipkbgjs9xyad9p21i3864hzinbh0wp9r";
    hash = "sha256-OV0O4LLxQ2LQiEHc1JTvScu35o2IWxo/hgn/COh2e7Y=";
  };

  build-system = [ setuptools ];

  postPatch = ''
    # only used to update the interal publicsuffix list
    substituteInPlace setup.py \