Commit 6a914e21 authored by OPNA2608's avatar OPNA2608
Browse files

clickable: Use class names in disabledTests 

`__structuredAttrs = true` now lets us build sub-expressions in disabledTests
(which was necessary for skipping only one test that uses /tmp).

We can make the test skipping more explicit now by including the class name, and excluding
test functions that reuse the same name.

In the case of the TestTemplates tests, we were disabling all of them, so just disable the class in general.

test_init_cmake_project_* are covered by test_init_cmake_project being disabled. I was unaware that disabledTests
only looks for substrings, not complete matches.
parent 89071ed8

pkgs/by-name/cl/clickable/package.nix

+19 −29
Original line number Diff line number Diff line
@@ -41,36 +41,26 @@ python3Packages.buildPythonApplication rec { 
    which

  ];



  disabledTests =

    [

      # Require running docker daemon

      "test_cpp_plugin"

      "test_godot_plugin"

      "test_html"

      "test_python"

      "test_qml_only"

      "test_rust"

  disabledTests = [

    # Requires running docker daemon

    "TestTemplates"



    # Expects /tmp to exist and not be a symlink

    # https://gitlab.com/clickable/clickable/-/issues/479

    "TestReviewCommand and test_run and not test_run_with_path_arg"

  ]

    # Tests do not work on non-amd64 platforms

  ++ lib.optionals (!stdenv.hostPlatform.isx86_64) [

    # hardcode amd64

      "test_arch"

      "test_restricted_arch"

    "TestArchitectures and test_arch and not test_arch_agnostic"

    "TestArchitectures and test_restricted_arch and not test_restricted_arch_env"



      # no -ide images on arm64

    # no -ide images on non-x86_64

    # https://gitlab.com/clickable/clickable/-/issues/478

      "test_command_overrided"

      "test_init_cmake_project"

      "test_init_cmake_project_exe_as_var"

      "test_init_cmake_project_no_exe"

      "test_init_cmake_project_no_to_prompt"

      "test_initialize_qtcreator_conf"

      "test_project_pre_configured"

      "test_recurse_replace"

    "TestIdeQtCreatorCommand and test_command_overrided"

    "TestIdeQtCreatorCommand and test_init_cmake_project"

    "TestIdeQtCreatorCommand and test_initialize_qtcreator_conf"

    "TestIdeQtCreatorCommand and test_project_pre_configured"

    "TestIdeQtCreatorCommand and test_recurse_replace"

  ];



  passthru.updateScript = gitUpdater { rev-prefix = "v"; };