Unverified Commit 69e0abf2 authored by Kevin Cox's avatar Kevin Cox
Browse files

mlt: Use selected version of ffmpeg for all dependencies

Right now if overriding ffmpeg (example `mlt.override { ffmpeg = ffmpeg-full; }`) will have unusual results as multiple versions of ffmpeg will end up linked into the resulting executable. I don't think it is well defined which will end up being used.

Notably for kdenlive which tries to use `ffmpeg-full` libaom-av1 was not available as the non-full ffmpeg was being used.

I don't know if this fix is the most maintainable solution, but it solves a particular problem and doesn't harm maintainability. It is likely wise to consider how we can manage full-binary library overrides better in the future.

Fixes: https://github.com/NixOS/nixpkgs/issues/272526
parent 58a1abdb
Loading
Loading
Loading
Loading
+1 −1
Original line number Diff line number Diff line
@@ -64,6 +64,7 @@ stdenv.mkDerivation rec {
  ];

  buildInputs = [
    (opencv4.override { inherit ffmpeg; })
    ffmpeg
    fftw
    frei0r
@@ -73,7 +74,6 @@ stdenv.mkDerivation rec {
    libvorbis
    libxml2
    movit
    opencv4
    rtaudio
    rubberband
    sox