Unverified Commit 6829310f authored by Silvan Mosberger's avatar Silvan Mosberger Committed by GitHub
Browse files

ci/eval/compare/maintainers: Handle nonexistent attribute in changedByNameAttrPaths (#499760)

parents add63bd0 16b37792

ci/eval/compare/maintainers.nix

+2 −0
Original line number Diff line number Diff line
@@ -96,6 +96,8 @@ let 
    (lib.filter (path: lib.length path > 3))

    (map (path: lib.elemAt path 3))

    (map lib.singleton)

    # Filter out new packages

    (lib.filter (attrPath: lib.hasAttrByPath attrPath pkgs))

  ];



  # An attribute can appear in affected *and* touched

ci/eval/compare/test.nix

+15 −0
Original line number Diff line number Diff line
@@ -138,6 +138,21 @@ let 
        ];

      };

    };

    testByNameNonExistentChanged = {

      expr = fun {

        pkgs = mockPkgs {

          packages = [ ];

        };

        # Happens when a new package was added to pkgs/by-name

        changedFiles = [ "pkgs/by-name/he/hello/sources.json" ];

        affectedAttrPaths = [ ];

      };

      expected = {

        packages = [ ];

        teams = { };

        users = { };

      };

    };

    testByNameReadmeChanged = {

      expr = fun {

        pkgs = mockPkgs {