Unverified Commit 66e3e178 authored by Jeremy Fleischman's avatar Jeremy Fleischman
Browse files

pympress: unbreak 

`pympress` currently crashes:

```console
$ pympress
Traceback (most recent call last):
  ...
  File "/usr/lib/python3.13/site-packages/pympress/builder.py", line 79, in __translate_widget_strings
    for str_prop in (prop.name for prop in a_widget.props if prop.value_type == GObject.TYPE_STRING):
                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.13/site-packages/pympress/builder.py", line 79, in <genexpr>
    for str_prop in (prop.name for prop in a_widget.props if prop.value_type == GObject.TYPE_STRING):
                                           ^^^^^^^^^^^^^^
TypeError: 'gi._gi.GPropsIter' object is not iterable
```

This isn't really a pympress bug, it's an unfortunate interaction
between Python 3 and pygobject. See
<https://github.com/Cimbali/pympress/issues/330> for details.
parent 65a740fa

pkgs/by-name/py/pympress/issue-330-gprops-iter-actually-iterable.patch

0 → 100644
+11 −0
Original line number Diff line number Diff line 
--- i/pympress/builder.py

+++ w/pympress/builder.py

@@ -76,7 +76,7 @@ class Builder(Gtk.Builder):

         Args:

             a_widget (:class:`~GObject.Object`): an object built by the builder, usually a widget

         """

-        for str_prop in (prop.name for prop in a_widget.props if prop.value_type == GObject.TYPE_STRING):

+        for str_prop in (prop.name for prop in list(a_widget.props) if prop.value_type == GObject.TYPE_STRING):

             try:

                 str_val = getattr(a_widget.props, str_prop)

                 if str_val:

pkgs/by-name/py/pympress/package.nix

+7 −0
Original line number Diff line number Diff line
@@ -30,6 +30,13 @@ python3Packages.buildPythonApplication rec { 
    babel

  ];



  patches = [

    # Workaround for a bug on Python >= 3.13+ and pygobject < 3.51.

    # This can go away once nixpkgs is using pygobject >= 3.51.

    # See <https://github.com/Cimbali/pympress/issues/330> for details.

    ./issue-330-gprops-iter-actually-iterable.patch

  ];



  dependencies =

    with python3Packages;

    [