Unverified Commit 66571c8e authored by Luflosi's avatar Luflosi
Browse files

nixos/phosh: enable services.graphical-desktop 

The `services.graphical-desktop` module (code in `nixos/modules/services/misc/graphical-desktop.nix`) is enabled automatically if `services.xserver.enable` or `services.displayManager.enable` is true but this does not cover `phosh`, so enable it manually.
My main motivation for this change is that `fonts.enableDefaultPackages` was set to false, unlike with all (most?) other desktop managers, which causes many characters to not be displayed.
Since enabling `services.graphical-desktop.enable` also enables `hardware.graphics.enable`, I removed the latter option from the `phosh` module.
The `services.graphical-desktop` module also sets `systemd.defaultUnit` to `"graphical.target"` if `services.xserver.autorun` or `services.displayManager.enable` are enabled, with the former option being enabled by default, so I also removed this option from the `phosh` module. This also better aligns with the intent of the user when disabling `services.xserver.autorun`.
parent 557398e2

nixos/modules/services/x11/desktop-managers/phosh.nix

+1 −2
Original line number Diff line number Diff line
@@ -157,7 +157,6 @@ in 
  };



  config = lib.mkIf cfg.enable {

    systemd.defaultUnit = "graphical.target";

    # Inspired by https://gitlab.gnome.org/World/Phosh/phosh/-/blob/main/data/phosh.service

    systemd.services.phosh = {

      wantedBy = [ "graphical.target" ];
@@ -213,7 +212,7 @@ in 


    security.pam.services.phosh = {};



    hardware.graphics.enable = lib.mkDefault true;

    services.graphical-desktop.enable = true;



    services.gnome.core-shell.enable = true;

    services.gnome.core-os-services.enable = true;