Commit 64ae43e9 authored by Thiago Kenji Okada's avatar Thiago Kenji Okada
Browse files

libretro: refactor mkLibretroCore function 

Separate it on its own separate file, remove some unnecessary
parameters and allow more flexibility.
parent 27b6e16a

pkgs/applications/emulators/retroarch/cores.nix

+462 −347

File changed.

Preview size limit exceeded, changes collapsed.

pkgs/applications/emulators/retroarch/default.nix

+1 −0
Original line number Diff line number Diff line
@@ -167,6 +167,7 @@ stdenv.mkDerivation rec { 
    platforms = platforms.unix;

    changelog = "https://github.com/libretro/RetroArch/blob/v${version}/CHANGES.md";

    maintainers = with maintainers; teams.libretro.members ++ [ matthewbauer kolbycrouch ];

    mainProgram = "retroarch";

    # FIXME: error while building in macOS:

    # "Undefined symbols for architecture <arch>"

    # See also retroarch/wrapper.nix that is also broken in macOS

pkgs/applications/emulators/retroarch/mkLibretroCore.nix

0 → 100644
+80 −0
Original line number Diff line number Diff line 
{ lib

, stdenv

, core

, makeWrapper

, retroarch

, zlib

, makefile ? "Makefile.libretro"

, extraBuildInputs ? [ ]

, extraNativeBuildInputs ? [ ]

  # Location of resulting RetroArch core on $out

, libretroCore ? "/lib/retroarch/cores"

  # The core filename is derivated from the core name

  # Setting `normalizeCore` to `true` will convert `-` to `_` on the core filename

, normalizeCore ? true

, ...

}@args:



let

  d2u = if normalizeCore then (lib.replaceChars [ "-" ] [ "_" ]) else (x: x);

  coreDir = placeholder "out" + libretroCore;

  coreFilename = "${d2u core}_libretro${stdenv.hostPlatform.extensions.sharedLibrary}";

  mainProgram = "retroarch-${core}";

  extraArgs = builtins.removeAttrs args [

    "lib"

    "stdenv"

    "core"

    "makeWrapper"

    "retroarch"

    "zlib"

    "makefile"

    "extraBuildInputs"

    "extraNativeBuildInputs"

    "libretroCore"

    "normalizeCore"

    "makeFlags"

    "meta"

  ];

in

stdenv.mkDerivation ({

  pname = "libretro-${core}";



  buildInputs = [ zlib ] ++ extraBuildInputs;

  nativeBuildInputs = [ makeWrapper ] ++ extraNativeBuildInputs;



  inherit makefile;



  makeFlags = [

    "platform=${{

      linux = "unix";

      darwin = "osx";

      windows = "win";

    }.${stdenv.hostPlatform.parsed.kernel.name} or stdenv.hostPlatform.parsed.kernel.name}"

    "ARCH=${{

      armv7l = "arm";

      armv6l = "arm";

      i686 = "x86";

    }.${stdenv.hostPlatform.parsed.cpu.name} or stdenv.hostPlatform.parsed.cpu.name}"

  ] ++ (args.makeFlags or [ ]);



  installPhase = ''

    runHook preInstall



    install -Dt ${coreDir} ${coreFilename}

    makeWrapper ${retroarch}/bin/retroarch $out/bin/${mainProgram} \

      --add-flags "-L ${coreDir}/${coreFilename} $@"



    runHook postInstall

  '';



  enableParallelBuilding = true;



  passthru = { inherit core libretroCore; };



  meta = with lib; {

    inherit mainProgram;

    inherit (retroarch.meta) platforms;

    homepage = "https://www.libretro.com/";

    maintainers = with maintainers; teams.libretro.members ++ [ hrdinka ];

  } // (args.meta or { });

} // extraArgs)