Unverified Commit 5eefeb3f authored by emilylange's avatar emilylange
Browse files

nixos/forgejo: leverage systemd-notify support

This feature goes all the way back to v1.20.0 (mid 2023) back when
Forgejo was still a soft-fork and simply used the nixos/gitea module.

The tl;dr:
nixos/gitea enabled it as part of the Gitea 1.20 bump PR, while Forgejo
was still at 1.19.4 and did not support this yet, causing Forgejo to
get restarted after 90s by systemd in a loop. This, among other things,
was part of the reason why Forgejo forked the nixos/gitea module into
nixos/forgejo and it since moving independently in nixpkgs.

systemd-notify provides more accurate service unit states over the
previous service type "simple".

Ref: b61919e5
Ref: 44aee345
parent 439e0a24
Loading
Loading
Loading
Loading
+1 −1
Original line number Diff line number Diff line
@@ -722,7 +722,7 @@ in
      '';

      serviceConfig = {
        Type = "simple";
        Type = "notify";
        User = cfg.user;
        Group = cfg.group;
        WorkingDirectory = cfg.stateDir;