Unverified Commit 59233ecd authored by Wolfgang Walther's avatar Wolfgang Walther
Browse files

top-level/release-attrpaths-superset: remove __attrsFailEvaluation

This doesn't seem to be necessary anymore. I confirmed by:
- Adding a lib.warn into the __attrsFailsEvaluation branch - never got
any.
- Removing it everywhere and running full Eval on it - no errors, no
rebuilds.
parent 4ad7d21c
Loading
Loading
Loading
Loading
+1 −3
Original line number Diff line number Diff line
@@ -431,8 +431,6 @@ rec {
    ];
  };

  plugins = callPackage ./plugins { } // {
    __attrsFailEvaluation = true;
  };
  plugins = callPackage ./plugins { };

}
+1 −6
Original line number Diff line number Diff line
@@ -18,12 +18,7 @@ lib.makeScope newScope (
      plugins = [ ];
    };

    # Prevent `pkgs/top-level/release-attrpaths-superset.nix` from recursing here.
    pidginPackages = self // {
      pidginPackages = self.pidginPackages // {
        __attrsFailEvaluation = true;
      };
    };
    pidginPackages = self;

    pidgin-indicator = callPackage ./pidgin-indicator { };

+0 −2
Original line number Diff line number Diff line
@@ -39,7 +39,6 @@ let
    lib.trivial.pipe extensions [
      (map (extension: lib.nameValuePair extension.extensionUuid extension))
      builtins.listToAttrs
      (attrs: attrs // { __attrsFailEvaluation = true; })
    ];

  # Map the list of extensions to an attrset based on the pname as key, which is more human readable than the UUID
@@ -80,7 +79,6 @@ rec {

  # Keep the last three versions in here
  gnomeExtensions = lib.trivial.pipe (gnome46Extensions // gnome47Extensions // gnome48Extensions) [
    (v: builtins.removeAttrs v [ "__attrsFailEvaluation" ])
    # Apply some custom patches for automatically packaged extensions
    (callPackage ./extensionOverrides.nix { })
    # Add all manually packaged extensions
+1 −6
Original line number Diff line number Diff line
@@ -89,12 +89,7 @@ in
      in
      {
        # Packages suitable for build-time, e.g. `build.rs`-type stuff.
        buildRustPackages = (selectRustPackage pkgsBuildHost).packages.stable // {
          # Prevent `pkgs/top-level/release-attrpaths-superset.nix` from recursing more than one level here.
          buildRustPackages = self.buildRustPackages // {
            __attrsFailEvaluation = true;
          };
        };
        buildRustPackages = (selectRustPackage pkgsBuildHost).packages.stable;
        # Analogous to stdenv
        rustPlatform = makeRustPlatform self.buildRustPackages;
        rustc-unwrapped = self.callPackage ./rustc.nix ({
+1 −5
Original line number Diff line number Diff line
@@ -31,12 +31,8 @@ let
      ghc
      extensible-self
      all-cabal-hashes
      buildHaskellPackages
      ;

    # Prevent `pkgs/top-level/release-attrpaths-superset.nix` from recursing here.
    buildHaskellPackages = buildHaskellPackages // {
      __attrsFailEvaluation = true;
    };
  };

  platformConfigurations =
Loading