Commit 58a0bf05 authored by Ihar Hrachyshka's avatar Ihar Hrachyshka
Browse files

python312Packages.webdataset: enable tests for torch.distributed 



torch.distributed module is now build on Darwin too, so we can enable
the tests.

test_wids.py failed with Permission denied because the test suite was
using the same global path to write test shard files to for all test
runs. If a previous test run created some shard files, consequent runs
failed. This patch sets WIDS_CACHE variable for tests to use a unique
path for these files for each build.

Signed-off-by: default avatarIhar Hrachyshka <ihar.hrachyshka@gmail.com>
parent ec3113e0

pkgs/development/python-modules/webdataset/default.nix

+4 −5
Original line number Diff line number Diff line
@@ -53,6 +53,10 @@ buildPythonPackage rec { 


  pythonImportsCheck = [ "webdataset" ];



  preCheck = ''

    export WIDS_CACHE=$TMPDIR

  '';



  disabledTests =

    [

      # requires network
@@ -77,8 +81,6 @@ buildPythonPackage rec { 
    ]

    ++ lib.optionals (stdenv.hostPlatform.isx86_64 && stdenv.hostPlatform.isDarwin) [

      "test_concurrent_access"

      # fails to patch 'init_process_group' from torch.distributed

      "TestDistributedChunkedSampler"

    ]

    ++ lib.optionals (stdenv.hostPlatform.isAarch64 && stdenv.hostPlatform.isLinux) [

      # segfaults on aarch64-linux
@@ -89,9 +91,6 @@ buildPythonPackage rec { 
    ];



  disabledTestPaths = lib.optionals stdenv.hostPlatform.isDarwin [

    # AttributeError: <module 'torch.distributed' from /nix/store/...

    "tests/wids/test_wids.py"



    # Issue with creating a temp file in the sandbox

    "tests/wids/test_wids_mmtar.py"

  ];