Commit 5873454b authored by Sebastián Mancilla's avatar Sebastián Mancilla
Browse files

shogun: fix compiler warnings 

Fix warnings related to virtual destruction. Kinda important to fix.
parent c812170c

pkgs/applications/science/machine-learning/shogun/default.nix

+7 −0
Original line number Diff line number Diff line
@@ -88,6 +88,13 @@ stdenv.mkDerivation rec { 
      sha256 = "sha256-AgJJKQA8vc5oKaTQDqMdwBR4hT4sn9+uW0jLe7GteJw=";

    })



    # Fix virtual destruction

    (fetchpatch {

      url = "https://github.com/shogun-toolbox/shogun/commit/ef0e4dc1cc4a33c9e6b17a108fa38a436de2d7ee.patch";

      sha256 = "sha256-a9Rm0ytqkSAgC3dguv8m3SwOSipb+VByBHHdmV0d63w=";

    })

    ./fix-virtual-destruction.patch



    # Fix compile errors with json-c

    # https://github.com/shogun-toolbox/shogun/pull/4104

    (fetchpatch {

pkgs/applications/science/machine-learning/shogun/fix-virtual-destruction.patch

0 → 100644
+20 −0
Original line number Diff line number Diff line 
From: Sebastián Mancilla <smancill@smancill.dev>

Subject: Fix virtual destruction



---

 src/shogun/solver/LDASolver.h | 2 +-

 1 file changed, 1 insertion(+), 1 deletion(-)



diff --git a/src/shogun/solver/LDASolver.h b/src/shogun/solver/LDASolver.h

index 9300a85c5..d500eca5d 100644

--- a/src/shogun/solver/LDASolver.h

+++ b/src/shogun/solver/LDASolver.h

@@ -87,7 +87,7 @@ namespace shogun

 			compute_within_cov();

 		}

 

-		~LDASolver()

+		virtual ~LDASolver()

 		{

 			SG_UNREF(m_features)

 			SG_UNREF(m_labels)