Unverified Commit 50ff7013 authored by Peder Bergebakken Sundt's avatar Peder Bergebakken Sundt Committed by GitHub
Browse files

python3Packages.pygame-{original,ce}: skip failing tests (#483604)

parents 5d777914 bce1254b

pkgs/development/python-modules/pygame-ce/default.nix

+2 −2
Original line number Diff line number Diff line
@@ -60,8 +60,8 @@ buildPythonPackage rec { 
      );

    })



    # Can be removed after the SDL 3.4.0 bump.

    ./skip-rle-tests.patch

    # https://github.com/pygame-community/pygame-ce/pull/3680#issuecomment-3796052119

    ./skip-failing-tests.patch

  ];



  postPatch = ''

pkgs/development/python-modules/pygame-ce/skip-failing-tests.patch

0 → 100644
+43 −0
Original line number Diff line number Diff line 
diff --git a/test/draw_test.py b/test/draw_test.py

index ed99f0ce9..0484ef53d 100644

--- a/test/draw_test.py

+++ b/test/draw_test.py

@@ -7496,6 +7496,10 @@ class DrawModuleTest(unittest.TestCase):

             with self.assertRaises(TypeError):

                 draw.polygon(surf, col, points, 0)

 

+    @unittest.skipIf(

+        True,

+        "https://github.com/pygame-community/pygame-ce/pull/3680#issuecomment-3796052119",

+    )

     def test_aafunctions_depth_segfault(self):

         """Ensure future commits don't break the segfault fixed by pull request

         https://github.com/pygame-community/pygame-ce/pull/3008

diff --git a/test/surface_test.py b/test/surface_test.py

index c2c91f4f5..35b9e1aaf 100644

--- a/test/surface_test.py

+++ b/test/surface_test.py

@@ -286,6 +286,7 @@ class SurfaceTypeTest(unittest.TestCase):

         for pt in test_utils.rect_outer_bounds(fill_rect):

             self.assertNotEqual(s1.get_at(pt), color)

 

+    @unittest.skipIf(True, "https://github.com/libsdl-org/sdl2-compat/issues/575")

     def test_fill_rle(self):

         """Test RLEACCEL flag with fill()"""

         color = (250, 25, 25, 255)

diff --git a/test/window_test.py b/test/window_test.py

index b8dd1f005..5b7939908 100644

--- a/test/window_test.py

+++ b/test/window_test.py

@@ -113,10 +113,7 @@ class WindowTypeTest(unittest.TestCase):

         self.win.always_on_top = False

         self.assertFalse(self.win.always_on_top)

 

-    @unittest.skipIf(

-        SDL < (2, 0, 18),

-        "requires SDL 2.0.18+",

-    )

+    @unittest.skipIf(True, "https://github.com/pygame-community/pygame-ce/pull/3680")

     def test_mouse_rect(self):

         self.win.mouse_rect = None

         self.assertIsNone(self.win.mouse_rect)

pkgs/development/python-modules/pygame-ce/skip-rle-tests.patch

deleted100644 → 0
+0 −12
Original line number Diff line number Diff line 
diff --git a/test/surface_test.py b/test/surface_test.py

index c2c91f4f5..58d916de8 100644

--- a/test/surface_test.py

+++ b/test/surface_test.py

@@ -435,6 +436,7 @@ class SurfaceTypeTest(unittest.TestCase):

         finally:

             pygame.display.quit()

 

+    @unittest.skipIf(True, "https://github.com/libsdl-org/SDL/issues/14424")

     def test_set_alpha__set_colorkey_rle(self):

         pygame.display.init()

         try:

pkgs/development/python-modules/pygame-original/default.nix

+4 −2
Original line number Diff line number Diff line
@@ -32,6 +32,9 @@ buildPythonPackage rec { 
  version = "2.6.1";

  pyproject = true;



  # https://github.com/NixOS/nixpkgs/pull/475917

  disabled = pythonAtLeast "3.14";



  src = fetchFromGitHub {

    owner = "pygame";

    repo = "pygame";
@@ -64,8 +67,7 @@ buildPythonPackage rec { 
    # mixer queue test returns busy queue when it shouldn't

    ./skip-mixer-test.patch



    # Can be removed with the next SDL3 bump.

    ./skip-rle-tests.patch

    ./skip-failing-tests.patch



    # https://github.com/pygame/pygame/pull/4497

    ./0001-Use-SDL_HasSurfaceRLE-when-available.patch

pkgs/development/python-modules/pygame-original/skip-failing-tests.patch

0 → 100644
+24 −0
Original line number Diff line number Diff line 
diff --git a/test/pixelarray_test.py b/test/pixelarray_test.py

index 7b1cf420..67b93d3d 100644

--- a/test/pixelarray_test.py

+++ b/test/pixelarray_test.py

@@ -990,6 +990,7 @@ class PixelArrayTypeTest(unittest.TestCase, TestMixin):

         self.assertEqual(w2, w)

         self.assertEqual(h2, h_slice)

 

+    @unittest.skipIf(True, "")

     def test_make_surface__subclassed_surface(self):

         """Ensure make_surface can handle subclassed surfaces."""

         expected_size = (3, 5)

diff --git a/test/surface_test.py b/test/surface_test.py

index b1147d27..8e1209ff 100644

--- a/test/surface_test.py

+++ b/test/surface_test.py

@@ -239,6 +239,7 @@ class SurfaceTypeTest(unittest.TestCase):

         for pt in test_utils.rect_outer_bounds(fill_rect):

             self.assertNotEqual(s1.get_at(pt), color)

 

+    @unittest.skipIf(True, "https://github.com/libsdl-org/sdl2-compat/issues/575")

     def test_fill_rle(self):

         """Test RLEACCEL flag with fill()"""

         color = (250, 25, 25, 255)