Unverified Commit 4ec83510 authored by Randy Eckenrode's avatar Randy Eckenrode
Browse files

qt6.qtmultimedia: drop old SDK compatibility patch 

Qt Multimediate is being built with a newer SDK that has the new
definition, so don’t bother to patch it out anymore. The symbol is
defined in a backwards compatible way, so it will still work on older
releases that don’t have it in their SDKs.
parent 4ad6c7f1

pkgs/development/libraries/qt-6/modules/qtmultimedia.nix

+0 −2
Original line number Diff line number Diff line
@@ -37,8 +37,6 @@ qtModule { 


  patches = [

    ../patches/fix-qtgui-include-incorrect-case.patch

    # Remove new constants since macOS 12+, since we build Qt with the macOS 11 SDK

    ../patches/qtmultimedia-darwin-revert-replace-deprecated-constant.patch

  ] ++ lib.optionals stdenv.hostPlatform.isMinGW [

    ../patches/qtmultimedia-windows-no-uppercase-libs.patch

    ../patches/qtmultimedia-windows-resolve-function-name.patch

pkgs/development/libraries/qt-6/patches/qtmultimedia-darwin-revert-replace-deprecated-constant.patch

deleted100644 → 0
+0 −50
Original line number Diff line number Diff line 
diff --git a/src/multimedia/darwin/qdarwinmediadevices.mm b/src/multimedia/darwin/qdarwinmediadevices.mm

index b0a108935..881066928 100644

--- a/src/multimedia/darwin/qdarwinmediadevices.mm

+++ b/src/multimedia/darwin/qdarwinmediadevices.mm

@@ -42,7 +42,7 @@ static AudioDeviceID defaultAudioDevice(QAudioDevice::Mode mode)

     const AudioObjectPropertyAddress propertyAddress = {

         selector,

         kAudioObjectPropertyScopeGlobal,

-        kAudioObjectPropertyElementMain,

+        kAudioObjectPropertyElementMaster,

     };

 

     if (auto audioDevice = getAudioObject<AudioDeviceID>(kAudioObjectSystemObject, propertyAddress,

@@ -77,7 +77,7 @@ static QList<QAudioDevice> availableAudioDevices(QAudioDevice::Mode mode)

 

     const AudioObjectPropertyAddress audioDevicesPropertyAddress = {

         kAudioHardwarePropertyDevices, kAudioObjectPropertyScopeGlobal,

-        kAudioObjectPropertyElementMain

+        kAudioObjectPropertyElementMaster

     };

 

     if (auto audioDevices = getAudioData<AudioDeviceID>(

@@ -130,11 +130,11 @@ static OSStatus audioDeviceChangeListener(AudioObjectID id, UInt32,

 

 static constexpr AudioObjectPropertyAddress listenerAddresses[] = {

     { kAudioHardwarePropertyDefaultInputDevice, kAudioObjectPropertyScopeGlobal,

-      kAudioObjectPropertyElementMain },

+      kAudioObjectPropertyElementMaster },

     { kAudioHardwarePropertyDefaultOutputDevice, kAudioObjectPropertyScopeGlobal,

-      kAudioObjectPropertyElementMain },

+      kAudioObjectPropertyElementMaster },

     { kAudioHardwarePropertyDevices, kAudioObjectPropertyScopeGlobal,

-      kAudioObjectPropertyElementMain }

+      kAudioObjectPropertyElementMaster }

 };

 

 static void setAudioListeners(QDarwinMediaDevices &instance)

diff --git a/src/multimedia/darwin/qmacosaudiodatautils_p.h b/src/multimedia/darwin/qmacosaudiodatautils_p.h

index 8cc2f8440..5cd6fced2 100644

--- a/src/multimedia/darwin/qmacosaudiodatautils_p.h

+++ b/src/multimedia/darwin/qmacosaudiodatautils_p.h

@@ -44,7 +44,7 @@ void printUnableToReadWarning(const char *logName, AudioObjectID objectID, const

 

 inline static AudioObjectPropertyAddress

 makePropertyAddress(AudioObjectPropertySelector selector, QAudioDevice::Mode mode,

-                    AudioObjectPropertyElement element = kAudioObjectPropertyElementMain)

+                    AudioObjectPropertyElement element = kAudioObjectPropertyElementMaster)

 {

     return { selector,

              mode == QAudioDevice::Input ? kAudioDevicePropertyScopeInput