Commit 43eca5c0 authored by Samuel Dionne-Riel's avatar Samuel Dionne-Riel
Browse files

maintainer-list: Fix M0ustach3 maintainer entry

Two different PRs, two different issues.

The first PR, chronologically-merged-in, #426687 introduced a new
module, and while reviewers “reviewed” the `meta.maintainers` entry,
they did not notice the maintainer was not in the maintainers list file.

 - https://github.com/NixOS/nixpkgs/pull/426687#discussion_r2311053832

Then, in #437310, merged a few days later, another new module was added
with M0ustach3 as a maintainer. At the very least, an attempt was made
in de66c73a to add the maintainer to the
list, but an unfortunate typo (or two?) in the maintainers list entry
means the two intended usage of the new entry still don't work.

The issue here is not from the contributors. The reviewers and
committers could have done better, but it's not even truly their fault.
The issue is the meta information in NixOS modules was never checked. In
any way AFAICT. Otherwise this would have been caught immediately, and
not four months later.

Anyway, the intent clearly is that the entry should matche the GitHub
username.
parent 5bb63173
Loading
Loading
Loading
Loading
+1 −1
Original line number Diff line number Diff line
@@ -15729,7 +15729,7 @@
    github = "M0streng0";
    githubId = 85799811;
  };
  m0ustache3 = {
  M0ustach3 = {
    name = "M0ustach3";
    github = "M0ustach3";
    githubId = 37956764;
+1 −1
Original line number Diff line number Diff line
@@ -195,5 +195,5 @@ in
    };
  };

  meta.maintainers = [ lib.maintainers.m0ustach3 ];
  meta.maintainers = [ lib.maintainers.M0ustach3 ];
}
+1 −1
Original line number Diff line number Diff line
@@ -984,7 +984,7 @@ in

  meta = {
    maintainers = with lib.maintainers; [
      m0ustach3
      M0ustach3
      tornax
      jk
    ];