Unverified Commit 436699df authored by Fabian Affolter's avatar Fabian Affolter Committed by GitHub
Browse files

Merge pull request #301555 from fabaff/pynetdicom-fix

python312Packages.pynetdicom: disable failing tests on Python 3.12
parents 23fae009 286a5bf7
Loading
Loading
Loading
Loading
+31 −19
Original line number Diff line number Diff line
{ lib
, stdenv
, buildPythonPackage
, fetchFromGitHub
, fetchpatch
, pydicom
, pyfakefs
, pytestCheckHook
, sqlalchemy
, pythonOlder
{
  lib,
  stdenv,
  buildPythonPackage,
  fetchFromGitHub,
  fetchpatch,
  pydicom,
  pyfakefs,
  pytestCheckHook,
  pythonAtLeast,
  pythonOlder,
  setuptools,
  sqlalchemy,
}:

buildPythonPackage rec {
  pname = "pynetdicom";
  version = "2.0.2";
  format = "setuptools";
  pyproject = true;

  disabled = pythonOlder "3.7";

  src = fetchFromGitHub {
    owner = "pydicom";
    repo = pname;
    rev = "v${version}";
    repo = "pynetdicom";
    rev = "refs/tags/v${version}";
    hash = "sha256-/JWQUtFBW4uqCbs/nUxj1pRBfTCXV4wcqTkqvzpdFrM=";
  };

@@ -32,9 +35,9 @@ buildPythonPackage rec {
    })
  ];

  propagatedBuildInputs = [
    pydicom
  ];
  build-system = [ setuptools ];

  dependencies = [ pydicom ];

  nativeCheckInputs = [
    pyfakefs
@@ -72,15 +75,24 @@ buildPythonPackage rec {
  disabledTestPaths = [
    # Ignore apps tests
    "pynetdicom/apps/tests/"
  ] ++ lib.optionals (pythonAtLeast "3.12") [
    # https://github.com/pydicom/pynetdicom/issues/924
    "pynetdicom/tests/test_assoc.py"
    "pynetdicom/tests/test_transport.py"
  ];

  pythonImportsCheck = [
    "pynetdicom"
  pythonImportsCheck = [ "pynetdicom" ];

  pytestFlagsArray = [
    # https://github.com/pydicom/pynetdicom/issues/923
    "-W"
    "ignore::pytest.PytestRemovedIn8Warning"
  ];

  meta = with lib; {
    description = "Python implementation of the DICOM networking protocol";
    homepage = "https://github.com/pydicom/pynetdicom";
    changelog = "https://github.com/pydicom/pynetdicom/releases/tag/v${version}";
    license = with licenses; [ mit ];
    maintainers = with maintainers; [ fab ];
    # Tests are not passing on Darwin/Aarch64, thus it's assumed that it doesn't work