Commit 3e11f713 authored by Ihar Hrachyshka's avatar Ihar Hrachyshka
Browse files

ovn: fix command presence detection during checkPhase 

The test suite uses `which` to detect if auxiliary dependencies like
scapy or tcpdump are installed on the system, and skips the tests using
these commands if not.

Problem is when `which` is missing, all such commands are detected as
missing, so some tests that could be safely run are unnecessarily
skipped.

Note: upstream should probably not swallow the error from missing
`which` and instead enforce its presence during build. Or better: use
`command -v` that is always present.
parent d8719a07

pkgs/by-name/ov/ovn/package.nix

+4 −0
Original line number Diff line number Diff line
@@ -19,6 +19,7 @@ 
  coreutils,

  gnugrep,

  gnused,

  which,

  makeWrapper,

}:

let
@@ -72,6 +73,9 @@ stdenv.mkDerivation (finalAttrs: { 
    pkg-config

    python3

    makeWrapper

    # NOTE: remove if OVN switches to `command -v`:

    # https://patchwork.ozlabs.org/project/ovn/patch/20260205004956.84602-3-ihar.hrachyshka@gmail.com/

    which # used in test suite to detect presence of commands

  ];



  buildInputs = [