Unverified Commit 3c9794d0 authored by Wolfgang Walther's avatar Wolfgang Walther
Browse files

workflows/eval: add eval summary before requesting reviewers 

This is to ensure that the eval summary is still set as commit status,
even when the review requests fail due to too many reviewers.
parent 5dec6c35

.github/workflows/eval.yml

+14 −14
Original line number Diff line number Diff line
@@ -295,20 +295,6 @@ jobs: 
          REPOSITORY: ${{ github.repository }}

          NUMBER: ${{ github.event.number }}



      - name: Requesting maintainer reviews

        run: |

          # maintainers.json contains GitHub IDs. Look up handles to request reviews from.

          # There appears to be no API to request reviews based on GitHub IDs

          jq -r 'keys[]' comparison/maintainers.json \

            | while read -r id; do gh api /user/"$id" --jq .login; done \

            | GH_TOKEN=${{ steps.app-token.outputs.token }} result/bin/request-reviewers.sh "$REPOSITORY" "$NUMBER" "$AUTHOR"



        env:

          GH_TOKEN: ${{ github.token }}

          REPOSITORY: ${{ github.repository }}

          NUMBER: ${{ github.event.number }}

          AUTHOR: ${{ github.event.pull_request.user.login }}



      - name: Add eval summary to commit statuses

        if: ${{ github.event_name == 'pull_request_target' }}

        run: |
@@ -328,3 +314,17 @@ jobs: 
          GH_TOKEN: ${{ github.token }}

          PR_HEAD_SHA: ${{ github.event.pull_request.head.sha }}

          NUMBER: ${{ github.event.number }}



      - name: Requesting maintainer reviews

        run: |

          # maintainers.json contains GitHub IDs. Look up handles to request reviews from.

          # There appears to be no API to request reviews based on GitHub IDs

          jq -r 'keys[]' comparison/maintainers.json \

            | while read -r id; do gh api /user/"$id" --jq .login; done \

            | GH_TOKEN=${{ steps.app-token.outputs.token }} result/bin/request-reviewers.sh "$REPOSITORY" "$NUMBER" "$AUTHOR"



        env:

          GH_TOKEN: ${{ github.token }}

          REPOSITORY: ${{ github.repository }}

          NUMBER: ${{ github.event.number }}

          AUTHOR: ${{ github.event.pull_request.user.login }}