Unverified Commit 3364d76c authored by Nick Cao's avatar Nick Cao
Browse files

circt: fix build with non clang stdenv 

lib.optionalString creates an empty string when the condition is false
And the circt test framework interprets this as disabling all tests
failing the build with `error: filter did not match any tests`
parent 8f56be21

pkgs/development/compilers/circt/default.nix

+2 −1
Original line number Diff line number Diff line
@@ -49,7 +49,8 @@ stdenv.mkDerivation rec { 
  #    https://github.com/NixOS/nixpkgs/issues/214945 discusses this issue.

  #

  # As a temporary fix, we disabled these tests when using clang stdenv

  LIT_FILTER_OUT = lib.optionalString stdenv.cc.isClang "CIRCT :: Target/ExportSystemC/.*\.mlir";

  # cannot use lib.optionalString as it creates an empty string, disabling all tests

  LIT_FILTER_OUT = if stdenv.cc.isClang then "CIRCT :: Target/ExportSystemC/.*\.mlir" else null;



  preConfigure = ''

    substituteInPlace test/circt-reduce/test/annotation-remover.mlir --replace "/usr/bin/env" "${coreutils}/bin/env"