Unverified Commit 2ef224ea authored by Gaétan Lepage's avatar Gaétan Lepage Committed by GitHub
Browse files

python3Packages.torch-geometric: skip failing tests on python>=3.14 (#481585)

parents 71c0c208 810209c2

pkgs/development/python-modules/compressai/default.nix

+11 −4
Original line number Diff line number Diff line
@@ -3,6 +3,7 @@ 
  stdenv,

  buildPythonPackage,

  fetchFromGitHub,

  pythonAtLeast,



  # build-system

  pybind11,
@@ -31,7 +32,7 @@ 
  pytestCheckHook,

}:



buildPythonPackage rec {

buildPythonPackage (finalAttrs: {

  pname = "compressai";

  version = "1.2.8";

  pyproject = true;
@@ -39,9 +40,9 @@ buildPythonPackage rec { 
  src = fetchFromGitHub {

    owner = "InterDigitalInc";

    repo = "CompressAI";

    tag = "v${version}";

    hash = "sha256-Fgobh7Q1rKomcqAT4kJl2RsM1W13ErO8sFB2urCqrCk=";

    tag = "v${finalAttrs.version}";

    fetchSubmodules = true;

    hash = "sha256-Fgobh7Q1rKomcqAT4kJl2RsM1W13ErO8sFB2urCqrCk=";

  };



  build-system = [
@@ -100,6 +101,12 @@ buildPythonPackage rec { 
    # Flaky (AssertionError: assert 0.08889999999999998 < 0.064445)

    "test_compiling"

    "test_find_close"

  ]

  ++ lib.optionals (pythonAtLeast "3.14") [

    # AttributeError: '...' object has no attribute '__annotations__'

    "test_gdn"

    "test_gdn1"

    "test_lower_bound_script"

  ];



  disabledTestPaths = lib.optionals stdenv.hostPlatform.isDarwin [
@@ -117,4 +124,4 @@ buildPythonPackage rec { 
    license = lib.licenses.bsd3Clear;

    maintainers = with lib.maintainers; [ GaetanLepage ];

  };

}
 
})

pkgs/development/python-modules/torch-geometric/default.nix

+58 −19
Original line number Diff line number Diff line
@@ -71,7 +71,7 @@ 
  pythonAtLeast,

}:



buildPythonPackage rec {

buildPythonPackage (finalAttrs: {

  pname = "torch-geometric";

  version = "2.7.0";

  pyproject = true;
@@ -79,7 +79,7 @@ buildPythonPackage rec { 
  src = fetchFromGitHub {

    owner = "pyg-team";

    repo = "pytorch_geometric";

    tag = version;

    tag = finalAttrs.version;

    hash = "sha256-xlOzpoYRoEfIRWSQoZbEPvUW43AMr3rCgIYnxwG/z3A=";

  };
@@ -165,9 +165,7 @@ buildPythonPackage rec { 
    ];

  };



  pythonImportsCheck = [

    "torch_geometric"

  ];

  pythonImportsCheck = [ "torch_geometric" ];



  nativeCheckInputs = [

    pytestCheckHook
@@ -249,9 +247,46 @@ buildPythonPackage rec { 


    # RuntimeError: Boolean value of Tensor with more than one value is ambiguous

    "test_feature_store"

  ]

  ++ lib.optionals (pythonAtLeast "3.14") [

    # TypeError: cannot pickle 'sqlite3.Connection' object

    "test_dataloader_on_disk_dataset"



    # AssertionError: assert False

    # assert utils.supports_bipartite_graphs('SAGEConv')

    "test_gnn_cheatsheet"



    # AttributeError: readonly attribute

    "test_fill_config_store"

    "test_register"

    "test_to_dataclass"



    # AttributeError: '...' object has no attribute '__annotations__'

    "test_degree_scaler_aggregation"

    "test_explain_message"

    "test_fused_aggregation"

    "test_gcn_conv_with_decomposed_layers"

    "test_hetero_dict_linear_jit"

    "test_hetero_linear_basic"

    "test_jit"

    "test_mlp"

    "test_multi_agg"

    "test_my_commented_conv"

    "test_my_conv_jit"

    "test_my_conv_jit_save"

    "test_my_default_arg_conv"

    "test_my_edge_conv_jit"

    "test_my_kwargs_conv"

    "test_my_multiple_aggr_conv_jit"

    "test_pickle"

    "test_sequential_jit"

    "test_torch_script"

    "test_traceable_my_conv_with_self_loops"

    "test_tuple_output_jit"

  ];



  disabledTestPaths = lib.optionals stdenv.hostPlatform.isDarwin [

  disabledTestPaths =

    lib.optionals stdenv.hostPlatform.isDarwin [

      # MPS (Metal) tests are failing when using `libtorch_cpu`.

      # Crashes in `structured_cat_out_mps`

      "test/nn/models/test_deep_graph_infomax.py::test_infomax_predefined_model[mps]"
@@ -262,13 +297,17 @@ buildPythonPackage rec { 
      "test/nn/norm/test_layer_norm.py::test_layer_norm[node-True-mps]"

      "test/nn/norm/test_layer_norm.py::test_layer_norm[node-False-mps]"

      "test/utils/test_scatter.py::test_group_cat[mps]"

    ]

    ++ lib.optionals (pythonAtLeast "3.14") [

      # AttributeError: '...' object has no attribute '__annotations__'

      "test/nn/aggr/test_aggr_utils.py"

    ];



  meta = {

    description = "Graph Neural Network Library for PyTorch";

    homepage = "https://github.com/pyg-team/pytorch_geometric";

    changelog = "https://github.com/pyg-team/pytorch_geometric/blob/${src.rev}/CHANGELOG.md";

    changelog = "https://github.com/pyg-team/pytorch_geometric/blob/${finalAttrs.src.tag}/CHANGELOG.md";

    license = lib.licenses.mit;

    maintainers = with lib.maintainers; [ GaetanLepage ];

  };

}
 
})