Unverified Commit 2a44ea3e authored by Reno Dakota's avatar Reno Dakota Committed by Vladimír Čunát
Browse files

samba: fix darwin 

the cups headers are part of the sdk but the library is not, which
causes configure to detect cups but the build fails with a link error.
explicitly enable / disable cups based on `enablePrinting` flag.
parent d16edfa9

pkgs/servers/samba/4.x.nix

+2 −1
Original line number Diff line number Diff line
@@ -128,7 +128,7 @@ stdenv.mkDerivation (finalAttrs: { 
    ++ optionals stdenv.hostPlatform.isDarwin [ libiconv ]

    ++ optionals enableLDAP [ openldap.dev python3Packages.markdown ]

    ++ optionals (!enableLDAP && stdenv.hostPlatform.isLinux) [ ldb talloc tevent ]

    ++ optional (enablePrinting && stdenv.hostPlatform.isLinux) cups

    ++ optional enablePrinting cups

    ++ optional enableMDNS avahi

    ++ optionals enableDomainController [ gpgme lmdb python3Packages.dnspython ]

    ++ optional enableRegedit ncurses
@@ -160,6 +160,7 @@ stdenv.mkDerivation (finalAttrs: { 
    "--sysconfdir=/etc"

    "--localstatedir=/var"

    "--disable-rpath"

    (lib.enableFeature enablePrinting "cups")

  ] ++ optional (!enableDomainController)

    "--without-ad-dc"

  ++ optionals (!enableLDAP) [