python3Packages.triton: 3.1.0 -> 3.3.1 (#419179)

  lib,

  stdenv,

  fetchFromGitHub,

  fetchpatch,

  pkgsBuildBuild,

  pkg-config,

  cmake,

in

stdenv.mkDerivation (finalAttrs: {

  pname = "triton-llvm";

  version = "19.1.0-rc1"; # One of the tags at https://github.com/llvm/llvm-project/commit/10dc3a8e916d73291269e5e2b82dd22681489aa1

  version = "21.0.0-git"; # See https://github.com/llvm/llvm-project/blob/main/cmake/Modules/LLVMVersion.cmake

  outputs =

    [

      "man"

    ];

  # See https://github.com/triton-lang/triton/blob/main/python/setup.py

  # and https://github.com/ptillet/triton-llvm-releases/releases

  # See https://github.com/triton-lang/triton/blob/main/cmake/llvm-hash.txt

  src = fetchFromGitHub {

    owner = "llvm";

    repo = "llvm-project";

    rev = "10dc3a8e916d73291269e5e2b82dd22681489aa1";

    hash = "sha256-9DPvcFmhzw6MipQeCQnr35LktW0uxtEL8axMMPXIfWw=";

    rev = "a66376b0dc3b2ea8a84fda26faca287980986f78";

    hash = "sha256-7xUPozRerxt38UeJxA8kYYxOQ4+WzDREndD2+K0BYkU=";

  };

  patches = [

    # glibc-2.40 support

    # [llvm-exegesis] Use correct rseq struct size #100804

    # https://github.com/llvm/llvm-project/issues/100791

    (fetchpatch {

      url = "https://github.com/llvm/llvm-project//commit/84837e3cc1cf17ed71580e3ea38299ed2bfaa5f6.patch";

      hash = "sha256-QKa+kyXjjGXwTQTEpmKZx5yYjOyBX8A8NQoIYUaGcIw=";

    })

  ];

  nativeBuildInputs =

    [

From 2751c5de5c61c90b56e3e392a41847f4c47258fd Mon Sep 17 00:00:00 2001

From: SomeoneSerge <else+aalto@someonex.net>

Date: Sun, 13 Oct 2024 14:16:48 +0000

Subject: [PATCH 1/3] _build: allow extra cc flags

---

 python/triton/runtime/build.py | 10 +++++++++-

 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/python/triton/runtime/build.py b/python/triton/runtime/build.py

index d7baeb286..d334dce77 100644

index 1b76548d4..2756dccdb 100644

--- a/python/triton/runtime/build.py

+++ b/python/triton/runtime/build.py

@@ -42,9 +42,17 @@ def _build(name, src, srcdir, library_dirs, include_dirs, libraries):

     py_include_dir = sysconfig.get_paths(scheme=scheme)["include"]

     include_dirs = include_dirs + [srcdir, py_include_dir]

     cc_cmd = [cc, src, "-O3", "-shared", "-fPIC", "-o", so]

@@ -33,5 +33,13 @@ def _build(name, src, srcdir, library_dirs, include_dirs, libraries):

     cc_cmd += [f'-l{lib}' for lib in libraries]

     cc_cmd += [f"-L{dir}" for dir in library_dirs]

     cc_cmd += [f"-I{dir}" for dir in include_dirs if dir is not None]

+

+    # Nixpkgs support branch

+    # Allows passing e.g. extra -Wl,-rpath

+        import shlex

+        cc_cmd.extend(shlex.split(cc_cmd_extra_flags))

+

     cc_cmd += [f'-l{lib}' for lib in libraries]

     cc_cmd += [f"-L{dir}" for dir in library_dirs]

-    cc_cmd += [f"-I{dir}" for dir in include_dirs]

+    cc_cmd += [f"-I{dir}" for dir in include_dirs if dir is not None]

     ret = subprocess.check_call(cc_cmd)

     if ret == 0:

     subprocess.check_call(cc_cmd, stdout=subprocess.DEVNULL)

     return so

-- 

2.46.0

From 587d1f3428eca63544238802f19e0be670d03244 Mon Sep 17 00:00:00 2001

From: SomeoneSerge <else@someonex.net>

Date: Mon, 29 Jul 2024 14:31:11 +0000

Subject: [PATCH] setup.py: introduce TRITON_OFFLINE_BUILD

To prevent any vendoring whatsoever

---

 python/setup.py | 26 ++++++++++++++++++++++++--

 1 file changed, 24 insertions(+), 2 deletions(-)

diff --git a/python/setup.py b/python/setup.py

index 73800ec40..4e5b04de4 100644

--- a/python/setup.py

+++ b/python/setup.py

@@ -112,6 +112,20 @@ def get_env_with_keys(key: list):

             return os.environ[k]

     return ""

+def is_offline_build() -> bool:

+    """

+    Downstream projects and distributions which bootstrap their own dependencies from scratch

+    and run builds in offline sandboxes

+    may set `TRITON_OFFLINE_BUILD` in the build environment to prevent any attempts at downloading

+    pinned dependencies from the internet or at using dependencies vendored in-tree.

+

+    Dependencies must be defined using respective search paths (cf. `syspath_var_name` in `Package`).

+    Missing dependencies lead to an early abortion.

+    Dependencies' compatibility is not verified.

+

+    Note that this flag isn't tested by the CI and does not provide any guarantees.

+    """

+    return os.environ.get("TRITON_OFFLINE_BUILD", "") != ""

 # --- third party packages -----

@@ -220,8 +234,14 @@ def get_thirdparty_packages(packages: list):

         if os.environ.get(p.syspath_var_name):

             package_dir = os.environ[p.syspath_var_name]

         version_file_path = os.path.join(package_dir, "version.txt")

-        if p.syspath_var_name not in os.environ and\

-           (not os.path.exists(version_file_path) or Path(version_file_path).read_text() != p.url):

+

+        input_defined = p.syspath_var_name not in os.environ

+        input_exists = input_defined and os.path.exists(version_file_path)

+        input_compatible = input_exists and Path(version_file_path).read_text() == p.url

+

+        if is_offline_build() and not input_defined:

+            raise RuntimeError(f"Requested an offline build but {p.syspath_var_name} is not set")

+        if not is_offline_build() and not input_compatible:

             with contextlib.suppress(Exception):

                 shutil.rmtree(package_root_dir)

             os.makedirs(package_root_dir, exist_ok=True)

@@ -245,6 +265,8 @@ def get_thirdparty_packages(packages: list):

 def download_and_copy(name, src_path, variable, version, url_func):

+    if is_offline_build():

+        return

     triton_cache_path = get_triton_cache_path()

     if variable in os.environ:

         return

-- 

2.45.1

From 7407cb03eec82768e333909d87b7668b633bfe86 Mon Sep 17 00:00:00 2001

From: SomeoneSerge <else+aalto@someonex.net>

Date: Sun, 13 Oct 2024 14:28:48 +0000

Subject: [PATCH 2/3] {nvidia,amd}/driver: short-circuit before ldconfig

---

 python/triton/runtime/build.py       | 6 +++---

 third_party/amd/backend/driver.py    | 7 +++++++

 third_party/nvidia/backend/driver.py | 3 +++

 3 files changed, 13 insertions(+), 3 deletions(-)

diff --git a/python/triton/runtime/build.py b/python/triton/runtime/build.py

index d334dce77..a64e98da0 100644

--- a/python/triton/runtime/build.py

+++ b/python/triton/runtime/build.py

@@ -42,6 +42,9 @@ def _build(name, src, srcdir, library_dirs, include_dirs, libraries):

     py_include_dir = sysconfig.get_paths(scheme=scheme)["include"]

     include_dirs = include_dirs + [srcdir, py_include_dir]

     cc_cmd = [cc, src, "-O3", "-shared", "-fPIC", "-o", so]

+    cc_cmd += [f'-l{lib}' for lib in libraries]

+    cc_cmd += [f"-L{dir}" for dir in library_dirs]

+    cc_cmd += [f"-I{dir}" for dir in include_dirs if dir is not None]

     # Nixpkgs support branch

     # Allows passing e.g. extra -Wl,-rpath

@@ -50,9 +53,6 @@ def _build(name, src, srcdir, library_dirs, include_dirs, libraries):

         import shlex

         cc_cmd.extend(shlex.split(cc_cmd_extra_flags))

-    cc_cmd += [f'-l{lib}' for lib in libraries]

-    cc_cmd += [f"-L{dir}" for dir in library_dirs]

-    cc_cmd += [f"-I{dir}" for dir in include_dirs if dir is not None]

     ret = subprocess.check_call(cc_cmd)

     if ret == 0:

         return so

diff --git a/third_party/amd/backend/driver.py b/third_party/amd/backend/driver.py

index 0a8cd7bed..aab8805f6 100644

index ca712f904..0961d2dda 100644

--- a/third_party/amd/backend/driver.py

+++ b/third_party/amd/backend/driver.py

@@ -24,6 +24,13 @@ def _get_path_to_hip_runtime_dylib():

             return env_libhip_path

         raise RuntimeError(f"TRITON_LIBHIP_PATH '{env_libhip_path}' does not point to a valid {lib_name}")

@@ -79,6 +79,9 @@ def _get_path_to_hip_runtime_dylib():

             return mmapped_path

         raise RuntimeError(f"memory mapped '{mmapped_path}' in process does not point to a valid {lib_name}")

+    # ...on release/3.1.x:

+    #         return mmapped_path

+    #     raise RuntimeError(f"memory mapped '{mmapped_path}' in process does not point to a valid {lib_name}")

+

+    if os.path.isdir("@libhipDir@"):

+        return ["@libhipDir@"]

+

     import site

diff --git a/third_party/nvidia/backend/driver.py b/third_party/nvidia/backend/driver.py

index 90f71138b..30fbadb2a 100644

index d088ec092..625de2db8 100644

--- a/third_party/nvidia/backend/driver.py

+++ b/third_party/nvidia/backend/driver.py

@@ -21,6 +21,9 @@ def libcuda_dirs():

@@ -23,6 +23,9 @@ def libcuda_dirs():

     if env_libcuda_path:

         return [env_libcuda_path]

     libs = subprocess.check_output(["/sbin/ldconfig", "-p"]).decode()

     # each line looks like the following:

     # libcuda.so.1 (libc6,x86-64) => /lib/x86_64-linux-gnu/libcuda.so.1

-- 

2.46.0

From e503e572b6d444cd27f1cdf124aaf553aa3a8665 Mon Sep 17 00:00:00 2001

From: SomeoneSerge <else+aalto@someonex.net>

Date: Mon, 14 Oct 2024 00:12:05 +0000

Subject: [PATCH 4/4] nvidia: allow static ptxas path

---

 third_party/nvidia/backend/compiler.py | 3 +++

 1 file changed, 3 insertions(+)

diff --git a/third_party/nvidia/backend/compiler.py b/third_party/nvidia/backend/compiler.py

index 6d7994923..6720e8f97 100644

index 960334744..269e22e6e 100644

--- a/third_party/nvidia/backend/compiler.py

+++ b/third_party/nvidia/backend/compiler.py

@@ -20,6 +20,9 @@ def _path_to_binary(binary: str):

@@ -38,6 +38,9 @@ def _path_to_binary(binary: str):

         os.path.join(os.path.dirname(__file__), "bin", binary),

     ]

+    import shlex

+    paths.extend(shlex.split("@nixpkgsExtraBinaryPaths@"))

+

     for bin in paths:

         if os.path.exists(bin) and os.path.isfile(bin):

             result = subprocess.check_output([bin, "--version"], stderr=subprocess.STDOUT)

-- 

2.46.0

     for path in paths:

         if os.path.exists(path) and os.path.isfile(path):

             result = subprocess.check_output([path, "--version"], stderr=subprocess.STDOUT)