Commit 29d3787c authored by Bas van Dijk's avatar Bas van Dijk Committed by github-actions[bot]
Browse files

wasmtime: fix build on aarch64-darwin 

The check phase fails on aarch64-darwin because of:

```
$ nix-build -A wasmtime
...
buildPhase completed in 1 minutes 41 seconds
Running phase: checkPhase
Executing cargoCheckHook
++ cargo test -j 10 --profile release --target aarch64-apple-darwin --frozen -- --test-threads=10
...
       >   error: linker `rust-lld` not found
       >     |
       >     = note: No such file or directory (os error 2)
       >
       >   error: could not compile `wasi-preview1-component-adapter` (lib) due to 1 previous error
```

I tried to bring `lld` into scope and set `RUSTFLAGS = "-C linker=lld`
but I couldn't get the tests to build. So I just disabled them on aarch64-darwin.

(cherry picked from commit cca07f13)
parent 3d3a7771

pkgs/development/interpreters/wasmtime/default.nix

+15 −6
Original line number Diff line number Diff line 
{ rustPlatform, fetchFromGitHub, Security, lib, stdenv }:

{ rustPlatform, rustfmt, fetchFromGitHub, Security, lib, stdenv }:



rustPlatform.buildRustPackage rec {

  pname = "wasmtime";
@@ -21,11 +21,20 @@ rustPlatform.buildRustPackage rec { 


  buildInputs = lib.optional stdenv.isDarwin Security;



  # rustfmt is brought into scope to fix the following

  #   warning: cranelift-codegen@0.108.0:

  #   Failed to run `rustfmt` on ISLE-generated code: Os

  #   { code: 2, kind: NotFound, message: "No such file or directory" }

  nativeBuildInputs = [ rustfmt ];



  doCheck = with stdenv.buildPlatform;

    # SIMD tests are only executed on platforms that support all

    # required processor features (e.g. SSE3, SSSE3 and SSE4.1 on x86_64):

    # https://github.com/bytecodealliance/wasmtime/blob/v9.0.0/cranelift/codegen/src/isa/x64/mod.rs#L220

  doCheck = with stdenv.buildPlatform; (isx86_64 -> sse3Support && ssse3Support && sse4_1Support);

  cargoTestFlags = ["--package" "wasmtime-runtime"];

    (isx86_64 -> sse3Support && ssse3Support && sse4_1Support) &&

    # The dependency `wasi-preview1-component-adapter` fails to build because of:

    # error: linker `rust-lld` not found

    !(isAarch64 && stdenv.isDarwin);



  postInstall = ''

    # move libs from out to dev