Unverified Commit 2663954f authored by Connor Baker's avatar Connor Baker Committed by GitHub
Browse files

Merge pull request #314707 from ConnorBaker/fix/python3Packages.apricot-select 

python3Packages.apricot-select: fixup dependency categories and disable tests
parents a23b7993 7568ee06

pkgs/development/python-modules/apricot-select/default.nix

+18 −2
Original line number Diff line number Diff line
@@ -2,6 +2,7 @@ 
  lib,

  buildPythonPackage,

  fetchFromGitHub,

  apricot-select,

  numba,

  numpy,

  pynose,
@@ -37,15 +38,15 @@ buildPythonPackage rec { 
  dependencies = [

    numba

    numpy

    scikit-learn

    scipy

    torchvision

    tqdm

  ];



  nativeCheckInputs = [

    pynose

    pytestCheckHook

    scikit-learn

    torchvision

  ];



  pythonImportsCheck = [ "apricot" ];
@@ -56,6 +57,21 @@ buildPythonPackage rec { 
    "tests/test_optimizers/test_knapsack_feature_based.py"

  ];



  # NOTE: These tests seem to be flaky.

  disabledTests = [

    "test_digits_modular"

    "test_digits_modular_object"

    "test_digits_modular_sparse"

    "test_digits_sqrt_modular"

    "test_digits_sqrt_modular_object"

    "test_digits_sqrt_modular_sparse"

  ];



  # NOTE: Tests are disabled by default because they can run for hours and timeout on Hydra.

  doCheck = false;



  passthru.tests.check = apricot-select.overridePythonAttrs { doCheck = true; };



  meta = with lib; {

    description = "Module for submodular optimization for the purpose of selecting subsets of massive data sets";

    homepage = "https://github.com/jmschrei/apricot";