Unverified Commit 24d4c532 authored by Jeremy Fleischman's avatar Jeremy Fleischman
Browse files

kikit: implement a workaround for non-deterministic `fetchFromGitHub` 

See https://github.com/NixOS/nixpkgs/issues/84312 for details.
parent a5f347c4

pkgs/by-name/ki/kikit/default.nix

+12 −1
Original line number Diff line number Diff line
@@ -35,7 +35,13 @@ buildPythonApplication rec { 
    owner = "yaqwsx";

    repo = "KiKit";

    tag = "v${version}";

    hash = "sha256-mwe/CajmQD5nDNYtQXRQm4vIJJiY7P5uFrvn8Ngjqc4=";

    hash = "sha256-HSAQJJqJMVh44wgOQm+0gteShLogklBFuIzWtoVTf9I=";

    # Upstream uses versioneer, which relies on gitattributes substitution.

    # This leads to non-reproducible archives on GitHub.

    # See https://github.com/NixOS/nixpkgs/issues/84312

    postFetch = ''

      rm "$out/kikit/_version.py"

    '';

  };



  build-system = [
@@ -75,6 +81,11 @@ buildPythonApplication rec { 
    "kikit"

  ];



  postPatch = ''

    # Recreate _version.py, deleted at fetch time due to non-reproducibility.

    echo 'def get_versions(): return {"version": "${version}"}' > kikit/_version.py

  '';



  preCheck = ''

    export PATH=$PATH:$out/bin

pkgs/by-name/ki/kikit/drop-versioneer.patch

0 → 100644
+14 −0
Original line number Diff line number Diff line 
diff --git a/setup.py b/setup.py

index 9351fc9..75dfb2c 100644

--- a/setup.py

+++ b/setup.py

@@ -66,9 +66,6 @@

         "solidpython>=1.1.2",

         "commentjson>=0.9"

     ],

-    setup_requires=[

-        "versioneer"

-    ],

     extras_require={

         "dev": ["pytest"],

     },