Commit 23fed8e6 authored by Neyts Zupan's avatar Neyts Zupan
Browse files

elmReview: 2.12.0 -> 2.13.1 

Rewriten from node2nix to buildNpmPackage. Previous work on this
started in https://github.com/NixOS/nixpkgs/pull/351767/files.

Also, added a simple test.

Refs https://github.com/Thaigersprint/thaigersprint-2025/issues/1
parent 534b2870

pkgs/development/compilers/elm/default.nix

+2 −0
Original line number Diff line number Diff line
@@ -47,6 +47,8 @@ lib.makeScope pkgs.newScope 


      elm-json = callPackage ./packages/elm-json { };



      elm-review = callPackage ./packages/elm-review { };



      elm-test-rs = callPackage ./packages/elm-test-rs { };



      elm-test = callPackage ./packages/elm-test { };

pkgs/development/compilers/elm/packages/elm-review/default.nix

0 → 100644
+45 −0
Original line number Diff line number Diff line 
{

  lib,

  buildNpmPackage,

  fetchFromGitHub,

  testers,

  elm-review,

}:



buildNpmPackage rec {

  pname = "elm-review";

  version = "2.13.1";



  src = fetchFromGitHub {

    owner = "jfmengels";

    repo = "node-elm-review";

    rev = "v${version}";

    hash = "sha256-f7VEYTvFbNbHnl/aGeQdDxCr/PtkaLBJw9FVpk2T9is=";

  };



  npmDepsHash = "sha256-5tSe/nK3X1MgX7uwTrFApw60i8c14ZWbk+IrgXMxTVc";



  postPatch = ''

    sed -i "s/elm-tooling install/echo 'skipping elm-tooling install'/g" package.json

  '';



  dontNpmBuild = true;



  passthru.tests.version = testers.testVersion {

    version = "${version}";

    package = elm-review;

    command = "elm-review --version";

  };



  meta = {

    changelog = "https://github.com/jfmengels/node-elm-review/blob/v${src.rev}/CHANGELOG.md";

    description = "Analyzes Elm projects, to help find mistakes before your users find them";

    mainProgram = "elm-review";

    homepage = "https://github.com/jfmengels/node-elm-review";

    license = lib.licenses.bsd3;

    maintainers = with lib.maintainers; [

      turbomack

      zupo

    ];

  };

}

pkgs/development/compilers/elm/packages/node/default.nix

+0 −10
Original line number Diff line number Diff line
@@ -91,16 +91,6 @@ with self; with elmLib; { 
      };

    };



  elm-review =

    nodePkgs.elm-review // {

      meta = with lib; nodePkgs.elm-review.meta // {

        description = "Analyzes Elm projects, to help find mistakes before your users find them";

        homepage = "https://package.elm-lang.org/packages/jfmengels/elm-review/${nodePkgs.elm-review.version}";

        license = licenses.bsd3;

        maintainers = [ maintainers.turbomack ];

      };

    };



  elm-language-server = nodePkgs."@elm-tooling/elm-language-server" // {

    meta = with lib; nodePkgs."@elm-tooling/elm-language-server".meta // {

      description = "Language server implementation for Elm";

pkgs/development/compilers/elm/packages/node/node-packages.json

+0 −1
Original line number Diff line number Diff line
@@ -13,7 +13,6 @@ 
  "create-elm-app",

  "elm-optimize-level-2",

  "elm-pages",

  "elm-review",

  "elm-git-install",

  "@dillonkearns/elm-graphql"

]

pkgs/development/node-packages/aliases.nix

+1 −0
Original line number Diff line number Diff line
@@ -95,6 +95,7 @@ mapAliases { 
  inherit (pkgs) dotenv-cli; # added 2024-06-26

  eask = pkgs.eask; # added 2023-08-17

  inherit (pkgs.elmPackages) elm-test;

  inherit (pkgs.elmPackages) elm-review;

  inherit (pkgs) eslint; # Added 2024-08-28

  inherit (pkgs) eslint_d; # Added 2023-05-26

  inherit (pkgs) eas-cli; # added 2025-01-08