Commit 2132639e authored by Daniel Fahey's avatar Daniel Fahey
Browse files

protonmail-bridge-gui: use regex for ICU version matching 

Replace specific ICU version match (.56 -> .73) with regex pattern \.[0-9][0-9] to match any 2-digit version number (10-99). This aligns with upstream's "BRIDGE-316: Update Qt to latest LTS version 6.8.2" while future-proofing for subsequent ICU versions.
ICU (International Components for Unicode) provides Unicode support. Binary compatibility is supported from ICU 3.0 onward, making this approach appropriate. Using generic .so symlinks offers flexibility with any compatible ICU version available on the system.
parent 55cde22d

pkgs/by-name/pr/protonmail-bridge-gui/package.nix

+1 −1
Original line number Diff line number Diff line
@@ -51,7 +51,7 @@ stdenv.mkDerivation (finalAttrs: { 
    find . -type f -name "CMakeLists.txt" -exec sed -i "/BridgeSetup\\.cmake/d" {} \;



    # Use the available ICU version

    sed -i "s/libicu\(i18n\|uc\|data\)\.so\.56/libicu\1.so/g" bridge-gui/DeployLinux.cmake

    sed -i "s/libicu\(i18n\|uc\|data\)\.so\.[0-9][0-9]/libicu\1.so/g" bridge-gui/DeployLinux.cmake



    # Create a Desktop Entry that uses a `protonmail-bridge-gui` binary without upstream's launcher

    sed "s/^\(Icon\|Exec\)=.*$/\1=protonmail-bridge-gui/" ../../../dist/proton-bridge.desktop > proton-bridge-gui.desktop