Unverified Commit 1f6c54c2 authored by Sergei Zimmerman's avatar Sergei Zimmerman
Browse files

curl: remove outdated meta.broken check for pkgsStatic and brotliSupport 

No longer accurate. pkgsStatic.curl does build when linked against brotli
and `curl --compressed -v "https://httpbin.org/brotli"` succeeds. Advertised
headers include:

* [HTTP/2] [1] [accept-encoding: deflate, gzip, br, zstd]
parent 2288b3e5

pkgs/by-name/cu/curlMinimal/package.nix

+2 −2
Original line number Diff line number Diff line
@@ -286,8 +286,8 @@ stdenv.mkDerivation (finalAttrs: { 
      Scrumplex

    ];

    platforms = lib.platforms.all;

    # Fails to link against static brotli or gss

    broken = stdenv.hostPlatform.isStatic && (brotliSupport || gssSupport);

    # Fails to link against static gss

    broken = stdenv.hostPlatform.isStatic && gssSupport;

    pkgConfigModules = [ "libcurl" ];

    mainProgram = "curl";

    identifiers.cpeParts = lib.meta.cpeFullVersionWithVendor "haxx" finalAttrs.version;

pkgs/top-level/all-packages.nix

+7 −11
Original line number Diff line number Diff line
@@ -2181,17 +2181,13 @@ with pkgs; 
    websocketSupport = true;

  };



  curl = curlMinimal.override (

    {

  curl = curlMinimal.override {

    idnSupport = true;

    pslSupport = true;

    zstdSupport = true;

    http3Support = true;

    }

    // lib.optionalAttrs (!stdenv.hostPlatform.isStatic) {

    brotliSupport = true;

    }

  );

  };



  curlWithGnuTls = curl.override {

    gnutlsSupport = true;