Commit 1ebd0f5a authored by Guy Chronister's avatar Guy Chronister
Browse files

fluidsynth: Migrate to by-name. 



fluidsynth: Add conditionals to provide default values on darwin

Simplify package.nix

Format to RFC style.

Apply suggestions from code review

Co-authored-by: default avatarPol Dellaiera <pol.dellaiera@protonmail.com>

 Fix nix file

fluidsynth: update meta attributes to use lib

fluidsynth: simplify derivation definition

fluidsynth: refactor derivation to use final attributes for versioning

fluidsynth: Update meta attribute structure

Update pkgs/by-name/fl/fluidsynth/package.nix

Co-authored-by: default avatarPol Dellaiera <pol.dellaiera@protonmail.com>

Add license.

Co-authored-by: default avatarPol Dellaiera <pol.dellaiera@protonmail.com>
parent 3eeaa42e

pkgs/applications/audio/fluidsynth/default.nix

deleted100644 → 0
+0 −37
Original line number Diff line number Diff line 
{ stdenv, lib, fetchFromGitHub, buildPackages, pkg-config, cmake

, alsa-lib, glib, libjack2, libsndfile, libpulseaudio

, AppKit, AudioUnit, CoreAudio, CoreMIDI, CoreServices

}:



stdenv.mkDerivation rec {

  pname = "fluidsynth";

  version = "2.4.3";



  src = fetchFromGitHub {

    owner = "FluidSynth";

    repo = "fluidsynth";

    rev = "v${version}";

    hash = "sha256-LaJcWrHgt/RzlDQmpzOjF/9ugD5d+8XWRt7pU3SM5Rk=";

  };



  outputs = [ "out" "dev" "man" ];



  nativeBuildInputs = [ buildPackages.stdenv.cc pkg-config cmake ];



  buildInputs = [ glib libsndfile libjack2 ]

    ++ lib.optionals stdenv.hostPlatform.isLinux [ alsa-lib libpulseaudio ]

    ++ lib.optionals stdenv.hostPlatform.isDarwin [ AppKit AudioUnit CoreAudio CoreMIDI CoreServices ];



  cmakeFlags = [

    "-Denable-framework=off"

  ];



  meta = with lib; {

    description = "Real-time software synthesizer based on the SoundFont 2 specifications";

    homepage    = "https://www.fluidsynth.org";

    license     = licenses.lgpl21Plus;

    maintainers = with maintainers; [ lovek323 ];

    platforms   = platforms.unix;

    mainProgram = "fluidsynth";

  };

}

pkgs/by-name/fl/fluidsynth/package.nix

0 → 100644
+72 −0
Original line number Diff line number Diff line 
{

  stdenv,

  darwin,

  lib,

  fetchFromGitHub,

  buildPackages,

  pkg-config,

  cmake,

  alsa-lib,

  glib,

  libjack2,

  libsndfile,

  libpulseaudio,

}:



stdenv.mkDerivation (finalAttrs: {

  pname = "fluidsynth";

  version = "2.4.3";



  src = fetchFromGitHub {

    owner = "FluidSynth";

    repo = "fluidsynth";

    tag = "v${finalAttrs.version}";

    hash = "sha256-LaJcWrHgt/RzlDQmpzOjF/9ugD5d+8XWRt7pU3SM5Rk=";

  };



  outputs = [

    "out"

    "dev"

    "man"

  ];



  nativeBuildInputs = [

    buildPackages.stdenv.cc

    pkg-config

    cmake

  ];



  buildInputs =

    [

      glib

      libsndfile

      libjack2

    ]

    ++ lib.optionals stdenv.hostPlatform.isLinux [

      alsa-lib

      libpulseaudio

    ]

    ++ lib.optionals stdenv.hostPlatform.isDarwin (

      with darwin.apple_sdk.frameworks;

      [

        AppKit

        AudioUnit

        CoreAudio

        CoreMIDI

        CoreServices

      ]

    );



  cmakeFlags = [

    "-Denable-framework=off"

  ];



  meta = {

    description = "Real-time software synthesizer based on the SoundFont 2 specifications";

    homepage = "https://www.fluidsynth.org";

    license = lib.licenses.lgpl21Plus;

    maintainers = with lib.maintainers; [ lovek323 ];

    platforms = lib.platforms.unix;

    mainProgram = "fluidsynth";

  };

})

pkgs/top-level/all-packages.nix

+0 −4
Original line number Diff line number Diff line
@@ -12908,10 +12908,6 @@ with pkgs; 
    hamlib = hamlib_4;

  };













  fluidsynth = callPackage ../applications/audio/fluidsynth {













    inherit (darwin.apple_sdk.frameworks) AppKit AudioUnit CoreAudio CoreMIDI CoreServices;













  };



























  fmit = libsForQt5.callPackage ../applications/audio/fmit { };





























  fnc = darwin.apple_sdk_11_0.callPackage ../applications/version-management/fnc { };